Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Graph to store a Pylibcugraph Graph (SG/MG Graph) #2394

Merged
merged 29 commits into from
Jul 22, 2022

Conversation

alexbarghi-nv
Copy link
Member

Closes #2373

@alexbarghi-nv alexbarghi-nv self-assigned this Jul 7, 2022
@alexbarghi-nv alexbarghi-nv added python non-breaking Non-breaking change labels Jul 7, 2022
@alexbarghi-nv alexbarghi-nv added this to the 22.08 milestone Jul 7, 2022
@alexbarghi-nv
Copy link
Member Author

rerun tests

@alexbarghi-nv alexbarghi-nv added the improvement Improvement / enhancement to an existing function label Jul 7, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2022

Codecov Report

Merging #2394 (50209c8) into branch-22.08 (5dd0267) will increase coverage by 0.50%.
The diff coverage is 66.66%.

❗ Current head 50209c8 differs from pull request most recent head fd3b844. Consider uploading reports for the commit fd3b844 to get more accurate results

@@               Coverage Diff                @@
##           branch-22.08    #2394      +/-   ##
================================================
+ Coverage         60.11%   60.62%   +0.50%     
================================================
  Files               102      102              
  Lines              5155     5234      +79     
================================================
+ Hits               3099     3173      +74     
- Misses             2056     2061       +5     
Impacted Files Coverage Δ
python/cugraph/cugraph/__init__.py 100.00% <ø> (ø)
python/cugraph/cugraph/dask/common/input_utils.py 22.13% <0.00%> (ø)
python/cugraph/cugraph/dask/common/mg_utils.py 30.43% <0.00%> (ø)
python/cugraph/cugraph/dask/comms/comms.py 34.06% <0.00%> (ø)
...ugraph/cugraph/dask/structure/mg_property_graph.py 18.56% <0.00%> (+0.07%) ⬆️
python/cugraph/cugraph/sampling/node2vec.py 81.81% <ø> (ø)
...ure/graph_implementation/simpleDistributedGraph.py 16.47% <28.57%> (+1.45%) ⬆️
...h/cugraph/dask/sampling/uniform_neighbor_sample.py 23.25% <30.00%> (+6.58%) ⬆️
python/cugraph/cugraph/dask/traversal/bfs.py 33.33% <42.85%> (+18.33%) ⬆️
python/cugraph/cugraph/structure/graph_classes.py 79.48% <50.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5dd0267...fd3b844. Read the comment docs.

@alexbarghi-nv alexbarghi-nv marked this pull request as ready for review July 15, 2022 15:10
@alexbarghi-nv alexbarghi-nv requested a review from a team as a code owner July 15, 2022 15:10
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just had some minor comments and questions.

@rlratzel
Copy link
Contributor

@gpucibot merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Update cugraph Graph classes to maintain a pylibcugraph SG/MGGraph instance
5 participants