Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Optimize cugraph.uniform_neighbor_sample #2433

Closed
Tracked by #3279
VibhuJawa opened this issue Jul 19, 2022 · 6 comments
Closed
Tracked by #3279

[FEA] Optimize cugraph.uniform_neighbor_sample #2433

VibhuJawa opened this issue Jul 19, 2022 · 6 comments
Assignees
Labels
improvement Improvement / enhancement to an existing function
Milestone

Comments

@VibhuJawa
Copy link
Member

Describe the solution you'd like and any additional context

We should optimize cugraph.uniform_neighbor_sample.

import cudf
import cugraph

df = cudf.read_parquet('/datasets/graph_nn/ogbn_products.parquet')
G = cugraph.Graph(directed=True)
G.from_cudf_edgelist(df,source='src',destination='dst',edge_attr='weight')
batch = G.nodes()[0:4096]
%%timeit 

sampled_g_cugraph = cugraph.uniform_neighbor_sample(G,
                                     start_list=batch,
                                     fanout_vals=[10],
                                     with_replacement=False
332 ms ± 847

Expected Performance : I would expect the performance to be around 8-9x better. More details in internal thread.

@VibhuJawa VibhuJawa added the ? - Needs Triage Need team to review and classify label Jul 19, 2022
@VibhuJawa
Copy link
Member Author

VibhuJawa commented Jul 20, 2022

Will be optimized by 50x 332 ms to 25 ms by #2394 .

Of that 25 ms only 6.61 ms seems to spent in the pylibcugraph_uniform_neighbor_sample call so we have more scope there.

@github-actions
Copy link

github-actions bot commented Sep 4, 2022

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@BradReesWork BradReesWork removed the GNN label Sep 20, 2022
@BradReesWork BradReesWork added improvement Improvement / enhancement to an existing function and removed ? - Needs Triage Need team to review and classify inactive-30d labels Oct 4, 2022
@BradReesWork BradReesWork added this to the 22.12 milestone Oct 4, 2022
@ChuckHastings ChuckHastings removed this from the 22.12 milestone Nov 28, 2022
@BradReesWork BradReesWork added this to the 23.02 milestone Jan 12, 2023
@BradReesWork BradReesWork modified the milestones: 23.02, 23.04 Jan 23, 2023
@kingmesal
Copy link

kingmesal commented Mar 8, 2023

@seunghwak or @VibhuJawa
Can you confirm if this is complete? Does anything else need to occur to close this?

@seunghwak
Copy link
Contributor

#3269 might be related to this issue no other issue tracking uniform neighbor sampling performance.

@kingmesal
Copy link

@VibhuJawa can you confirm whether or not #3269 fixes your issue?

@VibhuJawa
Copy link
Member Author

Lets close this issue. #3269 fixed most things

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function
Projects
None yet
Development

No branches or pull requests

5 participants