Update cugraph to with newest CMake features, including CPM for dependencies
#1585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use rapids-cmake HTTPS url
ajschmidt8
approved these changes
May 10, 2021
Codecov Report
@@ Coverage Diff @@
## branch-21.06 #1585 +/- ##
===============================================
Coverage ? 59.90%
===============================================
Files ? 79
Lines ? 3482
Branches ? 0
===============================================
Hits ? 2086
Misses ? 1396
Partials ? 0 Continue to review full report at Codecov.
|
Updates to get_raft and setuputils for changes for using rapids-…
trxcllnt
reviewed
May 18, 2021
trxcllnt
reviewed
May 18, 2021
trxcllnt
reviewed
May 18, 2021
Co-authored-by: Paul Taylor <[email protected]>
|
Thrust 1.12 compile errors should be fixed by rapidsai/raft#231. |
|
rerun tests |
The setuputils.py script will try to parse the `PINNED_TAG` arguments from `get_raft` and will fail if CMake variables are used.
Update setuputils to deduce cugraph minor/major version from cmakelists to allow dynamic pinning of RAFT
|
@robertmaynard one minor merge conflct |
Resolved the conflict. |
Update cuhornet hash, download the entire cuhornet git tree
|
@gpucibot merge |
|
rerun tests |
rapids-bot bot
pushed a commit
that referenced
this pull request
Jun 1, 2021
Similar to rapidsai/cuml#3901. After #1491 and #rapids-cmake and #1585, now at install time, the cugraph headers are being nested into `path/to/env/include/cugraph/cugraph` instead of just `path/to/env/include/cugraph/`. This, as far as I'm aware, is unintentional and unlike the rest of RAPIDS projects (cuDF, RMM and cuML). cc @trxcllnt @robertmaynard Authors: - Dante Gama Dessavre (https://github.com/dantegd) Approvers: - Chuck Hastings (https://github.com/ChuckHastings) - Robert Maynard (https://github.com/robertmaynard) - Seunghwa Kang (https://github.com/seunghwak) - Paul Taylor (https://github.com/trxcllnt) - Rick Ratzel (https://github.com/rlratzel) URL: #1630
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the
cugraphto be used viaCPMeither from a system installed version or from a build-directory.