Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Migrate CMakeLists files to use CPM #1539

Closed
rlratzel opened this issue Apr 16, 2021 · 5 comments
Closed

[ENH] Migrate CMakeLists files to use CPM #1539

rlratzel opened this issue Apr 16, 2021 · 5 comments
Assignees
Labels
? - Needs Triage Need team to review and classify

Comments

@rlratzel
Copy link
Contributor

rlratzel commented Apr 16, 2021

Discussed this with @dantegd - cuDF and cuML are moving to CPM, cuGraph should do the same for consistency and the benefit of added functionality:

  • ability to use preinstalled dependencies or download and build from source
  • better support for CUDA, GPU arches, etc. (I think?)
  • be up-to-date with the community's expectations
  • be able to copy patterns from other RAPIDS repos
  • addresses tech debt related to FetchContent calls that use commit hashes (eg. cuHornet), which have mistakenly used GIT_SHALLOW and broken builds when dependencies update their latest hash. (see Disabling shallow fetch for cuhornet #1535 )
@rlratzel rlratzel added the ? - Needs Triage Need team to review and classify label Apr 16, 2021
@rlratzel rlratzel self-assigned this Apr 16, 2021
@github-actions
Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@dantegd
Copy link
Member

dantegd commented May 23, 2021

Linking #1585

@ChuckHastings
Copy link
Collaborator

This is OBE. We migrated everything to use the rapids-make mechanism.

@dantegd
Copy link
Member

dantegd commented Jul 31, 2021

@ChuckHastings for curiosity, what does OBE mean? A quick google search gives me Order of the British Empire so that would be quite a status for the issue 😛

@ChuckHastings
Copy link
Collaborator

OBE = "Overcome By Events". We didn't intentionally do something to address this request, however other changes have made doing something for this issue unnecessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
? - Needs Triage Need team to review and classify
Projects
None yet
Development

No branches or pull requests

3 participants