-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove IncludeCategories
from .clang-format
#9876
Conversation
Note CI is failing because of #9870 not because of the clang-format changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-format changes look good. Part of me wants to fix the #include "..."
s that should be using <...>
revealed in this changeset, but that's not a blocker since the changes were automated and this PR touches a lot of files that would be time consuming to fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for this change, save for keeping the #include "header.hpp"
style of includes.
Please ignore if that's not the focus of changes here. I've flagged them as suggestion
s where I could, for easy correction.
Co-authored-by: MithunR <[email protected]>
Co-authored-by: MithunR <[email protected]>
Co-authored-by: MithunR <[email protected]>
Co-authored-by: MithunR <[email protected]>
Co-authored-by: MithunR <[email protected]>
Co-authored-by: MithunR <[email protected]>
It's all good. I committed them all, pulled down and reran clang-format. Thanks 👍 |
rerun tests |
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-22.02 #9876 +/- ##
================================================
- Coverage 10.49% 10.42% -0.07%
================================================
Files 119 119
Lines 20305 20479 +174
================================================
+ Hits 2130 2134 +4
- Misses 18175 18345 +170
Continue to review full report at Codecov.
|
rerun tests |
@gpucibot merge |
It was recently noticed that the `IncludeCategories`: ``` IncludeCategories: - Regex: '^<ext/.*\.h>' Priority: 2 - Regex: '^<.*\.h>' Priority: 1 - Regex: '^<.*' Priority: 2 - Regex: '.*' Priority: 3 ``` In the `.clang-format` are not really necessary as `ext` has no meaning in RAPIDS. This PR removes these. Note these changes are being made in all repos: * `cudf`: rapidsai/cudf#9876 * `rmm`: rapidsai/rmm#933 * `cuml`: rapidsai/cuml#4438 * `cugraph`: rapidsai/cugraph#1987 Authors: - Conor Hoekstra (https://github.com/codereport) Approvers: - Mark Harris (https://github.com/harrism) URL: #470
It was recently noticed that the `IncludeCategories`: ``` IncludeCategories: - Regex: '^<ext/.*\.h>' Priority: 2 - Regex: '^<.*\.h>' Priority: 1 - Regex: '^<.*' Priority: 2 - Regex: '.*' Priority: 3 ``` In the `.clang-format` are not really necessary as `ext` has no meaning in RAPIDS. This PR removes these. Note these changes are being made in all repos: * `cudf`: rapidsai/cudf#9876 * `rmm`: rapidsai/rmm#933 * `cuml`: rapidsai/cuml#4438 * `cugraph`: rapidsai/cugraph#1987 * `cuspatial`: rapidsai/cuspatial#470 Authors: - Conor Hoekstra (https://github.com/codereport) Approvers: - Brad Rees (https://github.com/BradReesWork) - Corey J. Nolet (https://github.com/cjnolet) URL: #412
It was recently noticed that the `IncludeCategories`: ``` IncludeCategories: - Regex: '^<ext/.*\.h>' Priority: 2 - Regex: '^<.*\.h>' Priority: 1 - Regex: '^<.*' Priority: 2 - Regex: '.*' Priority: 3 ``` In the `.clang-format` are not really necessary as `ext` has no meaning in RAPIDS. This PR removes these. Note these changes are being made in all repos: * `cudf`: rapidsai/cudf#9876 * `rmm`: rapidsai/rmm#933 * `cuml`: rapidsai/cuml#4438 Authors: - Conor Hoekstra (https://github.com/codereport) Approvers: - Chuck Hastings (https://github.com/ChuckHastings) URL: #1987
It was recently noticed that the `IncludeCategories`: ``` IncludeCategories: - Regex: '^<ext/.*\.h>' Priority: 2 - Regex: '^<.*\.h>' Priority: 1 - Regex: '^<.*' Priority: 2 - Regex: '.*' Priority: 3 ``` In the `.clang-format` are not really necessary as `ext` has no meaning in RAPIDS. This PR removes these. Note these changes are being made in all repos: * `cudf`: rapidsai/cudf#9876 * `rmm`: rapidsai/rmm#933 Authors: - Conor Hoekstra (https://github.com/codereport) Approvers: - William Hicks (https://github.com/wphicks) - Divye Gala (https://github.com/divyegala) URL: #4438
It was recently noticed that the `IncludeCategories`: ``` IncludeCategories: - Regex: '^<ext/.*\.h>' Priority: 2 - Regex: '^<.*\.h>' Priority: 1 - Regex: '^<.*' Priority: 2 - Regex: '.*' Priority: 3 ``` In the `.clang-format` are not really necessary as `ext` has no meaning in RAPIDS. This PR removes these. Note these changes are being made in all repos: * `cudf`: rapidsai/cudf#9876 * `rmm`: rapidsai/rmm#933 Authors: - Conor Hoekstra (https://github.com/codereport) Approvers: - William Hicks (https://github.com/wphicks) - Divye Gala (https://github.com/divyegala) URL: rapidsai#4438
It was recently noticed that the
IncludeCategories
:In the
.clang-format
are not really necessary asext
has no meaning in RAPIDS. This PR removes these.Depends on #9870.