Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOTFIX] Fix indexing into a single row of a MultiIndex #9870

Merged
merged 12 commits into from
Dec 9, 2021
Merged

[HOTFIX] Fix indexing into a single row of a MultiIndex #9870

merged 12 commits into from
Dec 9, 2021

Conversation

shwina
Copy link
Contributor

@shwina shwina commented Dec 8, 2021 •
edited by vyasr
Loading

Given a dataframe gdf, this PR fixes indexing the behavior of two types of indexing: 1) gdf.loc[x] (as opposed to gdf.loc[x, y] where the column is also specified) and 2) gdf.iloc[x], which failed erroneously.

@shwina shwina requested a review from a team as a code owner December 8, 2021 20:20
@shwina shwina requested review from marlenezw and skirui-source and removed request for a team December 8, 2021 20:20
@github-actions github-actions bot added the Python Affects Python cuDF API. label Dec 8, 2021
@shwina shwina marked this pull request as draft December 8, 2021 20:22
@shwina shwina added non-breaking Non-breaking change bug Something isn't working labels Dec 8, 2021
@shwina shwina marked this pull request as ready for review December 8, 2021 20:39
@codecov
Copy link

codecov bot commented Dec 8, 2021 •
edited
Loading

Codecov Report

Merging #9870 (7bb5a61) into branch-21.12 (a93d333) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 7bb5a61 differs from pull request most recent head 24b1689. Consider uploading reports for the commit 24b1689 to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.12    #9870      +/-   ##
================================================
- Coverage         10.60%   10.60%   -0.01%     
================================================
  Files               118      118              
  Lines             20081    20082       +1     
================================================
  Hits               2130     2130              
- Misses            17951    17952       +1
Impacted Files Coverage Δ
python/cudf/cudf/core/multiindex.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a93d333...24b1689. Read the comment docs.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@shwina shwina mentioned this pull request Dec 8, 2021
Closed
@shwina shwina requested a review from a team as a code owner December 9, 2021 02:00
@github-actions github-actions bot added CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. labels Dec 9, 2021
@vyasr
Copy link
Contributor

vyasr commented Dec 9, 2021

@robertmaynard for some reason we're seeing the DOWNLOAD_ONLY argument to rapids_cpm_find being formatted all of a sudden, which is causing CI failures. That change to the format file was merged in rapidsai/rapids-cmake#94 over a month ago, any idea why it's suddenly triggering failures?

@raydouglass I apologize for lumping the formatting change into this PR. I'm happy to split it out if you prefer, but I figured that fewer hotfix PRs would be better at this stage. Let me know how you'd like me to proceed with that.

@vyasr vyasr removed the libcudf Affects libcudf (C++/CUDA) code. label Dec 9, 2021
@robertmaynard
Copy link
Contributor

@robertmaynard for some reason we're seeing the DOWNLOAD_ONLY argument to rapids_cpm_find being formatted all of a sudden, which is causing CI failures. That change to the format file was merged in rapidsai/rapids-cmake#94 over a month ago, any idea why it's suddenly triggering failures?

I think it is due to how we pull rapids-cmake format file via main instead of the current 'nearest` branch. ( https://github.com/rapidsai/cudf/blob/branch-22.02/ci/checks/style.sh#L17 )

So before 21.12 was released, main pointed at 21.10 and therefore we didn't have the latest changes.

@raydouglass
Copy link
Member

@raydouglass I apologize for lumping the formatting change into this PR. I'm happy to split it out if you prefer, but I figured that fewer hotfix PRs would be better at this stage. Let me know how you'd like me to proceed with that.

This is fine

brandon-b-miller
brandon-b-miller approved these changes Dec 9, 2021
View reviewed changes
Copy link
Contributor

@brandon-b-miller brandon-b-miller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python approval

@shwina shwina requested a review from a team as a code owner December 9, 2021 15:58
@github-actions github-actions bot added gpuCI libcudf Affects libcudf (C++/CUDA) code. labels Dec 9, 2021
@codereport codereport mentioned this pull request Dec 9, 2021
Merged
@mayankanand007 mayankanand007 mentioned this pull request Dec 9, 2021
Merged
@raydouglass raydouglass merged commit 0930f71 into rapidsai:branch-21.12 Dec 9, 2021
@mythrocks mythrocks mentioned this pull request Dec 9, 2021
Merged
rapids-bot bot pushed a commit that referenced this pull request Dec 12, 2021
@codereport
Remove IncludeCategories from .clang-format (#9876)
d23bcb4 
It was recently noticed that the `IncludeCategories`:
```
IncludeCategories:
  - Regex:           '^<ext/.*\.h>'
    Priority:        2
  - Regex:           '^<.*\.h>'
    Priority:        1
  - Regex:           '^<.*'
    Priority:        2
  - Regex:           '.*'
    Priority:        3
```
In the `.clang-format` are not really necessary as `ext` has no meaning in RAPIDS. This PR removes these.

Depends on #9870.

Authors:
  - Conor Hoekstra (https://github.com/codereport)

Approvers:
  - Nghia Truong (https://github.com/ttnghia)
  - Bradley Dice (https://github.com/bdice)
  - MithunR (https://github.com/mythrocks)
  - Ram (Ramakrishna Prabhu) (https://github.com/rgsl888prabhu)

URL: #9876
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandon-b-miller brandon-b-miller brandon-b-miller approved these changes

@ttnghia ttnghia ttnghia approved these changes

@raydouglass raydouglass raydouglass approved these changes

@robertmaynard robertmaynard robertmaynard approved these changes

@marlenezw marlenezw Awaiting requested review from marlenezw marlenezw is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@skirui-source skirui-source Awaiting requested review from skirui-source skirui-source is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
bug Something isn't working CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@shwina @vyasr @robertmaynard @raydouglass @ttnghia @brandon-b-miller @taureandyernv