Remove IncludeCategories from .clang-format
#4438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wphicks
added
non-breaking
wphicks
approved these changes
Dec 9, 2021
This was referenced Dec 9, 2021
rapids-bot bot
pushed a commit
to rapidsai/cuspatial
that referenced
this pull request
Dec 14, 2021
It was recently noticed that the `IncludeCategories`:
```
IncludeCategories:
- Regex: '^<ext/.*\.h>'
Priority: 2
- Regex: '^<.*\.h>'
Priority: 1
- Regex: '^<.*'
Priority: 2
- Regex: '.*'
Priority: 3
```
In the `.clang-format` are not really necessary as `ext` has no meaning in RAPIDS. This PR removes these.
Note these changes are being made in all repos:
* `cudf`: rapidsai/cudf#9876
* `rmm`: rapidsai/rmm#933
* `cuml`: rapidsai/cuml#4438
* `cugraph`: rapidsai/cugraph#1987
Authors:
- Conor Hoekstra (https://github.com/codereport)
Approvers:
- Mark Harris (https://github.com/harrism)
URL: #470
rapids-bot bot
pushed a commit
to rapidsai/raft
that referenced
this pull request
Dec 16, 2021
It was recently noticed that the `IncludeCategories`:
```
IncludeCategories:
- Regex: '^<ext/.*\.h>'
Priority: 2
- Regex: '^<.*\.h>'
Priority: 1
- Regex: '^<.*'
Priority: 2
- Regex: '.*'
Priority: 3
```
In the `.clang-format` are not really necessary as `ext` has no meaning in RAPIDS. This PR removes these.
Note these changes are being made in all repos:
* `cudf`: rapidsai/cudf#9876
* `rmm`: rapidsai/rmm#933
* `cuml`: rapidsai/cuml#4438
* `cugraph`: rapidsai/cugraph#1987
* `cuspatial`: rapidsai/cuspatial#470
Authors:
- Conor Hoekstra (https://github.com/codereport)
Approvers:
- Brad Rees (https://github.com/BradReesWork)
- Corey J. Nolet (https://github.com/cjnolet)
URL: #412
rapids-bot bot
pushed a commit
to rapidsai/cugraph
that referenced
this pull request
Dec 17, 2021
It was recently noticed that the `IncludeCategories`:
```
IncludeCategories:
- Regex: '^<ext/.*\.h>'
Priority: 2
- Regex: '^<.*\.h>'
Priority: 1
- Regex: '^<.*'
Priority: 2
- Regex: '.*'
Priority: 3
```
In the `.clang-format` are not really necessary as `ext` has no meaning in RAPIDS. This PR removes these.
Note these changes are being made in all repos:
* `cudf`: rapidsai/cudf#9876
* `rmm`: rapidsai/rmm#933
* `cuml`: rapidsai/cuml#4438
Authors:
- Conor Hoekstra (https://github.com/codereport)
Approvers:
- Chuck Hastings (https://github.com/ChuckHastings)
URL: #1987
|
@codereport CI failures me are unrelated to this PR, we're triaging them currently |
Awesome! I will fold the changes in once they are ready. |
|
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-22.02 #4438 +/- ##
===============================================
Coverage ? 85.75%
===============================================
Files ? 236
Lines ? 19310
Branches ? 0
===============================================
Hits ? 16560
Misses ? 2750
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
@gpucibot merge |
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
It was recently noticed that the `IncludeCategories`:
```
IncludeCategories:
- Regex: '^<ext/.*\.h>'
Priority: 2
- Regex: '^<.*\.h>'
Priority: 1
- Regex: '^<.*'
Priority: 2
- Regex: '.*'
Priority: 3
```
In the `.clang-format` are not really necessary as `ext` has no meaning in RAPIDS. This PR removes these.
Note these changes are being made in all repos:
* `cudf`: rapidsai/cudf#9876
* `rmm`: rapidsai/rmm#933
Authors:
- Conor Hoekstra (https://github.com/codereport)
Approvers:
- William Hicks (https://github.com/wphicks)
- Divye Gala (https://github.com/divyegala)
URL: rapidsai#4438
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was recently noticed that the
IncludeCategories:In the
.clang-formatare not really necessary asexthas no meaning in RAPIDS. This PR removes these.Note these changes are being made in all repos:
cudf: RemoveIncludeCategoriesfrom.clang-formatcudf#9876rmm: RemoveIncludeCategoriesfrom.clang-formatrmm#933