Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement DataFrame pct_change #9805

Merged
merged 19 commits into from
Feb 17, 2022
Merged

Implement DataFrame pct_change #9805

merged 19 commits into from
Feb 17, 2022

Conversation

skirui-source
Copy link
Contributor

@skirui-source skirui-source commented Dec 1, 2021 •
edited
Loading

Fixes: #9603

Next steps:

@skirui-source skirui-source added feature request New feature or request Python Affects Python cuDF API. labels Dec 1, 2021
@skirui-source skirui-source self-assigned this Dec 1, 2021
@skirui-source skirui-source added the non-breaking Non-breaking change label Dec 1, 2021
@codecov
Copy link

codecov bot commented Dec 1, 2021 •
edited
Loading

Codecov Report

Merging #9805 (eaf8fa7) into branch-22.04 (a7d88cd) will increase coverage by 0.23%.
The diff coverage is n/a.

❗ Current head eaf8fa7 differs from pull request most recent head c3c36fb. Consider uploading reports for the commit c3c36fb to get more accurate results

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.04    #9805      +/-   ##
================================================
+ Coverage         10.42%   10.65%   +0.23%     
================================================
  Files               119      122       +3     
  Lines             20603    20909     +306     
================================================
+ Hits               2148     2228      +80     
- Misses            18455    18681     +226
Impacted Files Coverage Δ
python/cudf/cudf/_fuzz_testing/fuzzer.py 0.00% <ø> (ø)
python/cudf/cudf/_fuzz_testing/io.py 0.00% <ø> (ø)
python/cudf/cudf/_fuzz_testing/main.py 0.00% <ø> (ø)
python/cudf/cudf/_version.py 0.00% <ø> (ø)
python/cudf/cudf/comm/gpuarrow.py 0.00% <ø> (ø)
python/cudf/cudf/core/_base_index.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/categorical.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/column.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/datetime.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/methods.py 0.00% <ø> (ø)
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 183eec3...c3c36fb. Read the comment docs.

@github-actions github-actions bot added CMake CMake build issue Java Affects Java cuDF API. libcudf Affects libcudf (C++/CUDA) code. labels Dec 2, 2021
@github-actions github-actions bot removed Java Affects Java cuDF API. CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. labels Dec 2, 2021
@github-actions
Copy link

github-actions bot commented Jan 8, 2022

This PR has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this PR if it is no longer required. Otherwise, please respond with a comment indicating any updates. This PR will be labeled inactive-90d if there is no activity in the next 60 days.

@shwina shwina changed the base branch from branch-22.02 to branch-22.04 January 20, 2022 21:22
@skirui-source skirui-source marked this pull request as ready for review February 10, 2022 10:14
@skirui-source skirui-source requested a review from a team as a code owner February 10, 2022 10:14
@beckernick beckernick removed their request for review February 15, 2022 14:23
isVoid
isVoid approved these changes Feb 16, 2022
View reviewed changes
Copy link
Contributor

@isVoid isVoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have much to add here. I think after this we can start thinking about moving diff and pct_change to indexed_frame so that we get both function for Series for free.

python/cudf/cudf/tests/test_dataframe.py Outdated Show resolved Hide resolved
@skirui-source
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit f5ec4b2 into rapidsai:branch-22.04 Feb 17, 2022
@isVoid isVoid mentioned this pull request Feb 17, 2022
Closed
@skirui-source skirui-source deleted the pct_change branch March 12, 2022 03:32
@skirui-source skirui-source mentioned this pull request Mar 16, 2022
Closed
@shwina shwina mentioned this pull request Mar 23, 2022
Closed
@skirui-source skirui-source mentioned this pull request Jun 24, 2022
Merged
rapids-bot bot pushed a commit that referenced this pull request Jul 18, 2022
@skirui-source
Implement Groupby pct_change (#11144)
f220e90 
Subsequent to #9805, this PR adds support for Groupby.pct_change()

Fixes #9606
Replaces #10444

Authors:
  - Sheilah Kirui (https://github.com/skirui-source)

Approvers:
  - Ashwin Srinath (https://github.com/shwina)

URL: #11144
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beckernick beckernick beckernick left review comments

@karthikeyann karthikeyann karthikeyann approved these changes

@galipremsagar galipremsagar Awaiting requested review from galipremsagar galipremsagar is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@vyasr vyasr Awaiting requested review from vyasr

@isVoid isVoid Awaiting requested review from isVoid

Assignees

@skirui-source skirui-source

Labels
feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] DataFrame pct_change
4 participants
@skirui-source @karthikeyann @beckernick @isVoid