Skip to content

Commit

Permalink
added link to created bug-fix libcudf ticket
Browse files Browse the repository at this point in the history
  • Loading branch information
skirui-source committed Feb 17, 2022
1 parent 0f68434 commit c3c36fb
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
4 changes: 3 additions & 1 deletion python/cudf/cudf/core/column/column.py
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,9 @@ def _fill(
return self

def shift(self, offset: int, fill_value: ScalarLike) -> ColumnBase:
# link to the libcudf ticket you will create
# libcudf currently doesn't handle case when offset > len(df)
# ticket to fix the bug in link below:
# https://github.com/rapidsai/cudf/issues/10314
if abs(offset) > len(self):
if fill_value is None:
return column_empty_like(self, masked=True)
Expand Down
2 changes: 1 addition & 1 deletion python/cudf/cudf/tests/test_dataframe.py
Original file line number Diff line number Diff line change
Expand Up @@ -9190,7 +9190,7 @@ def test_dataframe_rename_duplicate_column():
@pytest.mark.parametrize(
"data",
[
np.random.RandomState(seed=10).randint(-50, 50, (25, 30)),
np.random.RandomState(seed=10).randint(-50, 50, (10, 10)),
np.random.RandomState(seed=10).random_sample((4, 4)),
np.array([1.123, 2.343, 5.890, 0.0]),
{"a": [1.123, 2.343, np.nan, np.nan], "b": [None, 3, 9.08, None]},
Expand Down

0 comments on commit c3c36fb

Please sign in to comment.