Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Groupby pct_change #11144

Merged
merged 21 commits into from
Jul 18, 2022
Merged

Implement Groupby pct_change #11144

merged 21 commits into from
Jul 18, 2022

Conversation

skirui-source
Copy link
Contributor

Subsequent to #9805, this PR adds support for Groupby.pct_change()

Fixes #9606
Replaces #10444

@skirui-source skirui-source added feature request New feature or request 2 - In Progress Currently a work in progress Python Affects Python cuDF API. non-breaking Non-breaking change labels Jun 24, 2022
@skirui-source skirui-source mentioned this pull request Jun 24, 2022
Closed
karthikeyann
karthikeyann reviewed Jun 29, 2022
View reviewed changes
Copy link
Contributor

@karthikeyann karthikeyann left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍
axis=0 arg is missing.

@codecov
Copy link

codecov bot commented Jul 13, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.08@29918e3). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.08   #11144   +/-   ##
===============================================
  Coverage                ?   86.30%           
===============================================
  Files                   ?      144           
  Lines                   ?    22761           
  Branches                ?        0           
===============================================
  Hits                    ?    19645           
  Misses                  ?     3116           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29918e3...584dbe2. Read the comment docs.

@skirui-source skirui-source mentioned this pull request Jul 13, 2022
Closed
@skirui-source skirui-source marked this pull request as ready for review July 13, 2022 20:43
@skirui-source skirui-source requested a review from a team as a code owner July 13, 2022 20:43
@skirui-source skirui-source requested review from galipremsagar, isVoid, karthikeyann and shwina and removed request for galipremsagar and isVoid July 13, 2022 20:43
shwina
shwina approved these changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@shwina shwina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shwina
Copy link
Contributor

shwina commented Jul 18, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit f220e90 into rapidsai:branch-22.08 Jul 18, 2022
@skirui-source skirui-source deleted the groupby.pct_change branch July 18, 2022 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shwina shwina shwina approved these changes

@karthikeyann karthikeyann Awaiting requested review from karthikeyann

Assignees
No one assigned
Labels
2 - In Progress Currently a work in progress feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Groupby pct_change
3 participants
@skirui-source @shwina @karthikeyann