Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Pearson correlation for sort groupby (python) #9166

Merged
merged 149 commits into from
Nov 30, 2021
Merged

Add Pearson correlation for sort groupby (python) #9166

merged 149 commits into from
Nov 30, 2021

Conversation

skirui-source
Copy link
Contributor

Fixes: #8691

@skirui-source skirui-source added feature request New feature or request 2 - In Progress Currently a work in progress Python Affects Python cuDF API. non-breaking Non-breaking change labels Sep 2, 2021
@skirui-source skirui-source self-assigned this Sep 2, 2021
@github-actions github-actions bot added CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. labels Sep 2, 2021
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

isVoid
isVoid approved these changes Nov 18, 2021
View reviewed changes
Copy link
Contributor

@isVoid isVoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just got one small suggestion, else lgtm.

python/cudf/cudf/core/groupby/groupby.py Outdated Show resolved Hide resolved
@skirui-source
Copy link
Contributor Author

rerun tests

vyasr
vyasr requested changes Nov 23, 2021
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions then this should be good to go!

python/cudf/cudf/core/groupby/groupby.py Show resolved Hide resolved
python/cudf/cudf/core/groupby/groupby.py Outdated Show resolved Hide resolved
python/cudf/cudf/core/groupby/groupby.py Outdated Show resolved Hide resolved
python/cudf/cudf/core/groupby/groupby.py Outdated Show resolved Hide resolved
python/cudf/cudf/core/groupby/groupby.py Outdated Show resolved Hide resolved
python/cudf/cudf/core/groupby/groupby.py Outdated Show resolved Hide resolved
@skirui-source skirui-source requested a review from vyasr November 30, 2021 00:35
@skirui-source
Copy link
Contributor Author

rerun tests

vyasr
vyasr approved these changes Nov 30, 2021
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@skirui-source
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 991136c into rapidsai:branch-22.02 Nov 30, 2021
@mayankanand007 mayankanand007 mentioned this pull request Dec 10, 2021
Merged
5 tasks
rapids-bot bot pushed a commit that referenced this pull request Feb 17, 2022
@mayankanand007
Add covariance for sort groupby (python) (#9889)
fe37c0e 
This PR adds the functionality to perform `.cov()` on a `GroupBy` object and completes #1268

Related issue: #1268
Related PRs: #9154, #9166, #9492 

Next steps:

- [ ] Fix Symmetry problem [PR 10098](#10098 (comment)): avoid computing the covariance/ correlation between the same colums twice
- [ ] 	Consolidate  both `cov()` and `corr()`
- [ ] Fix #10303
- [ ] Add `cov `bindings in `aggregation.pyx` (separate PR): [comment](#9889 (comment))
- [ ] Simplify `combine_columns` after #10153 covers `interleave_columns`: [comment](#9889 (comment))

Authors:
  - Mayank Anand (https://github.com/mayankanand007)
  - Michael Wang (https://github.com/isVoid)
  - Sheilah Kirui (https://github.com/skirui-source)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Michael Wang (https://github.com/isVoid)
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #9889
@skirui-source skirui-source mentioned this pull request Mar 2, 2022
Merged
rapids-bot bot pushed a commit that referenced this pull request Mar 12, 2022
@skirui-source
Consolidate .cov and .corr for sort groupby (#10386)
9304ee6 
Follow up  PR to consolidate the implementations of PRs #9166 and #9889

Authors:
  - Sheilah Kirui (https://github.com/skirui-source)

Approvers:
  - Michael Wang (https://github.com/isVoid)

URL: #10386
@skirui-source skirui-source deleted the pearson_coeff branch March 12, 2022 03:31
@vyasr vyasr added 4 - Needs Review Waiting for reviewer to review or respond and removed 4 - Needs cuDF (Python) Reviewer labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karthikeyann karthikeyann karthikeyann approved these changes

@mayankanand007 mayankanand007 mayankanand007 approved these changes

@isVoid isVoid isVoid approved these changes

@vyasr vyasr vyasr approved these changes

@devavret devavret Awaiting requested review from devavret devavret was automatically assigned from rapidsai/cudf-cpp-codeowners

@beckernick beckernick Awaiting requested review from beckernick

@cwharris cwharris Awaiting requested review from cwharris

@shwina shwina Awaiting requested review from shwina

Assignees

@skirui-source skirui-source

Labels
4 - Needs Review Waiting for reviewer to review or respond feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Groupby correlation (Pearson)
8 participants
@skirui-source @karthikeyann @vyasr @cwharris @shwina @beckernick @isVoid @mayankanand007