Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Exploit Symmetry for groupby.corr and groupby.cov #10098

Open
isVoid opened this issue Jan 20, 2022 · 1 comment
Open

[FEA] Exploit Symmetry for groupby.corr and groupby.cov #10098

isVoid opened this issue Jan 20, 2022 · 1 comment
Labels
feature request New feature or request good first issue Good for newcomers Python Affects Python cuDF API.

Comments

@isVoid
Copy link
Contributor

isVoid commented Jan 20, 2022

In #9889 (comment), @bdice made an observation that due to symmetry, there's a chance of utilizing that to reduce computation by only applying the upper half of the matrix. In an attempt to reduce the scope of the PR, this is the issue that tracks the suggestion separately. If applicable, groupby.corr should also share the logic.

cc @skirui-source
@isVoid isVoid added feature request New feature or request Needs Triage Need team to review and classify labels Jan 20, 2022
@isVoid isVoid changed the title [FEA] Utilize Symmetry for groupby.corr and groupby.cov [FEA] Exploit Symmetry for groupby.corr and groupby.cov Jan 20, 2022
@isVoid isVoid mentioned this issue Jan 20, 2022
Merged
5 tasks
rapids-bot bot pushed a commit that referenced this issue Feb 17, 2022
@mayankanand007
Add covariance for sort groupby (python) (#9889)
fe37c0e 
This PR adds the functionality to perform `.cov()` on a `GroupBy` object and completes #1268

Related issue: #1268
Related PRs: #9154, #9166, #9492 

Next steps:

- [ ] Fix Symmetry problem [PR 10098](#10098 (comment)): avoid computing the covariance/ correlation between the same colums twice
- [ ] 	Consolidate  both `cov()` and `corr()`
- [ ] Fix #10303
- [ ] Add `cov `bindings in `aggregation.pyx` (separate PR): [comment](#9889 (comment))
- [ ] Simplify `combine_columns` after #10153 covers `interleave_columns`: [comment](#9889 (comment))

Authors:
  - Mayank Anand (https://github.com/mayankanand007)
  - Michael Wang (https://github.com/isVoid)
  - Sheilah Kirui (https://github.com/skirui-source)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Michael Wang (https://github.com/isVoid)
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #9889
@github-actions
Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@bdice bdice added good first issue Good for newcomers and removed Needs Triage Need team to review and classify labels Mar 3, 2022
@GregoryKimball GregoryKimball added the Python Affects Python cuDF API. label Nov 21, 2022
@vyasr vyasr added this to cuDF Python Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request good first issue Good for newcomers Python Affects Python cuDF API.
Projects
cuDF Python
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bdice @GregoryKimball @isVoid