Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate .cov and .corr for sort groupby #10386

Merged
merged 14 commits into from
Mar 12, 2022
Merged

Consolidate .cov and .corr for sort groupby #10386

merged 14 commits into from
Mar 12, 2022

Conversation

skirui-source
Copy link
Contributor

@skirui-source skirui-source commented Mar 2, 2022 •
edited
Loading

Follow up PR to consolidate the implementations of PRs #9166 and #9889

@skirui-source skirui-source added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 2, 2022
@skirui-source skirui-source self-assigned this Mar 2, 2022
@codecov
Copy link

codecov bot commented Mar 2, 2022 •
edited
Loading

Codecov Report

Merging #10386 (6dfb4a5) into branch-22.04 (b613394) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.04   #10386      +/-   ##
================================================
+ Coverage         86.13%   86.15%   +0.01%     
================================================
  Files               139      139              
  Lines             22460    22438      -22     
================================================
- Hits              19347    19332      -15     
+ Misses             3113     3106       -7
Impacted Files Coverage Δ
python/cudf/cudf/io/parquet.py 92.70% <ø> (ø)
python/cudf/cudf/core/column/column.py 89.16% <100.00%> (+0.17%) ⬆️
python/cudf/cudf/core/dataframe.py 93.57% <100.00%> (ø)
python/cudf/cudf/core/frame.py 91.72% <100.00%> (ø)
python/cudf/cudf/core/groupby/groupby.py 91.57% <100.00%> (+0.08%) ⬆️
python/cudf/cudf/core/single_column_frame.py 97.01% <100.00%> (ø)
python/cudf/cudf/core/column/string.py 88.39% <0.00%> (+0.12%) ⬆️
python/cudf/cudf/core/tools/datetimes.py 84.49% <0.00%> (+0.30%) ⬆️
python/cudf/cudf/core/column/lists.py 90.56% <0.00%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f29c8d9...6dfb4a5. Read the comment docs.

@skirui-source skirui-source marked this pull request as ready for review March 10, 2022 00:15
@skirui-source skirui-source requested a review from a team as a code owner March 10, 2022 00:15
@skirui-source skirui-source requested review from isVoid and charlesbluca and removed request for isVoid March 10, 2022 00:15
@skirui-source skirui-source requested a review from isVoid March 11, 2022 20:46
isVoid
isVoid approved these changes Mar 11, 2022
View reviewed changes
Copy link
Contributor

@isVoid isVoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

python/cudf/cudf/core/groupby/groupby.py Outdated Show resolved Hide resolved
@skirui-source
Copy link
Contributor Author

@gpucibot rerun tests

@skirui-source
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 9304ee6 into rapidsai:branch-22.04 Mar 12, 2022
@skirui-source skirui-source deleted the cov_corr branch March 12, 2022 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isVoid isVoid isVoid approved these changes

@charlesbluca charlesbluca Awaiting requested review from charlesbluca charlesbluca is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@skirui-source skirui-source

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skirui-source @isVoid