-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructuring Contributing doc
[skip ci]
#9026
Conversation
Can one of the admins verify this patch? |
This PR takes into account the change proposed here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work on this @iskode! I love the new structure - it greatly improves the flow of the document! Left a few suggestions that I think could help with clarity.
Co-authored-by: Ashwin Srinath <[email protected]>
Co-authored-by: Ashwin Srinath <[email protected]>
Co-authored-by: Ashwin Srinath <[email protected]>
Co-authored-by: Ashwin Srinath <[email protected]>
Co-authored-by: Ashwin Srinath <[email protected]>
Co-authored-by: Ashwin Srinath <[email protected]>
Co-authored-by: Ashwin Srinath <[email protected]>
should we not add instructions for java developers? |
That's a good question. @jlowe any thoughts here?
That would be great! Personally, I don't have any experience with developing those libraries, so I'd ask |
Feel free to lift instructions from the Java README or link to that document from here. If instructions are copied then we should probably have the Java README point back to the contributing doc to avoid duplicating instructions and allowing them to accidentally diverge over time. |
I think linking |
Can you clarify what you mean by this? I think I understand what you mean for Python, e.g.: hacking directly on deployed source files from the install, but that doesn't have an equivalent in Java. |
Ok @jlowe , thank you for recalling me. Yes java is a compiled language so edit mode makes only sense for python. |
Co-authored-by: Ashwin Srinath <[email protected]>
Co-authored-by: Ashwin Srinath <[email protected]>
Co-authored-by: Ashwin Srinath <[email protected]>
Co-authored-by: Ashwin Srinath <[email protected]>
Co-authored-by: Ashwin Srinath <[email protected]>
Co-authored-by: Ashwin Srinath <[email protected]>
Co-authored-by: Ashwin Srinath <[email protected]>
I have incorporated suggested changes and refactor subsection titles to make them clear and short. |
Thanks @iskode -- there's one last change I would ask for: we are inconsistent here about including the prompt ( My apologies for the back and forth on this PR - really appreciate your patience and excellent improvements to this doc :) |
You're right because even me I always copy and paste.
No problem, I really enjoy the process of thinking/suggesting ideas back and forth. |
Thank you @shwina for the suggestions. I've removed all prompt ( $ ) in the doc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM. @robertmaynard could you please review/approve when you have a chance. Thanks!
Co-authored-by: Robert Maynard <[email protected]>
Co-authored-by: Robert Maynard <[email protected]>
Contributing doc
Contributing doc
[skip ci]
ok to test |
@gpucibot merge |
This PR is related to the raised issue here. It is a refactoring of the contributing doc with instructions to locally build
cuDF
in edit mode.