Fix cudf doc test instructions [skip-ci] #8742
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
shwina
reviewed
Jul 15, 2021
harrism
changed the title
|
Moved this to |
|
@vyasr @shwina @iskode I saw this on the 21.12 project board. I will update for 22.02 and approve it. This fix matches the behavior of the rapids-compose development environment, which I fixed 2 months ago: trxcllnt/rapids-compose#46 |
|
Thank you @bdice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the contributing doc, the line:
py.test -v cudfraises an error:ImportError while importing test module '/media/ikone/Win10/github/cudf/python/cudf/cudf/benchmarks/bench_cudf_io.py'.Hint: make sure your test modules/packages have valid Python names.Traceback: /home/ikone/utils/miniconda3/envs/cudf_dev/lib/python3.8/importlib/__init__.py:127: in import_module return _bootstrap._gcd_import(name[level:], package, level) cudf/cudf/benchmarks/bench_cudf_io.py:7: in <module> from conftest import option E ImportError: cannot import name 'option' from 'conftest' (/media/ikone/Win10/github/cudf/python/cudf/cudf/tests/conftest.pyIn fact it runs also benchmark tests which must be ran separately not with cudf unit tests located at
cudf/cudf/tests. This creates a conflict betweenconftest.pyfrom benchmark and unit tests where the latter overrides the former.Information about benchmark tests are mentioned in README.md:
py.test -v cudf/benchmarks/