Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructuring
Contributing doc
[skip ci] #9026Restructuring
Contributing doc
[skip ci] #9026Changes from 22 commits
d9ed1ba
23ea87c
0a0b0ab
edf19e9
69eb32a
e03693d
ec951fb
6e1d901
45b0169
f4e9451
1ea8cdb
f8f37db
5900635
0cd676a
e68ed18
f7515cb
d3073d0
7e167ae
2859c1d
f804fbe
df483bf
e7159b1
4d24281
f96e46e
793867a
98de65a
dd93ade
f792bf2
7a628ac
9706118
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's avoid grouping contributors into "C++", "cudf Python", etc., Many contributions span multiple components.
Instead, I think we should just provide two sets of instructions, one just for building the library, and another for building and running tests. For example, something like:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is already the case for Python libraries where we have one set for building in edit mode and the other for running tests. This concerns
libcudf
andlibcudf_kafka
.