-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix memory read error in get_dremel_data in page_enc.cu #8995
Fix memory read error in get_dremel_data in page_enc.cu #8995
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #8995 +/- ##
===============================================
Coverage ? 10.60%
===============================================
Files ? 116
Lines ? 19064
Branches ? 0
===============================================
Hits ? 2022
Misses ? 17042
Partials ? 0 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought hard but there's really no other easy way to achieve this.
@gpucibot merge |
Reference issue #8883 and depends on PR #8884
The
PARQUET_TEST
fails with cuda-memcheck when called with thermm_mode=cuda
parameter. The 4-byte read error is caused by this code logic:The
scan_it
lambda will read one offset value passed the end due to theoff[i + 1]
statement. Theexclusive_scan
does not actually use the last element so the code was modified to just returnfalse
if the index,i
is greater than or equal to the size of the offsets column.