Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory read error in get_dremel_data in page_enc.cu #8995

Merged
merged 4 commits into from
Aug 13, 2021
Merged

Fix memory read error in get_dremel_data in page_enc.cu #8995

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3c2107a
Fix memory read error in get_dremel_data in page_enc.cu
davidwendt Aug 9, 2021
06cca67
Merge branch 'branch-21.10' into bug-memcheck-parquet-page-enc
davidwendt Aug 12, 2021
197afbb
Merge branch 'branch-21.10' into bug-memcheck-parquet-page-enc
davidwendt Aug 12, 2021
df219e9
Merge branch 'branch-21.10' into bug-memcheck-parquet-page-enc
davidwendt Aug 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions cpp/src/io/parquet/page_enc.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1966,9 +1966,9 @@ dremel_data get_dremel_data(column_view h_col,

// Scan to get distance by which each offset value is shifted due to the insertion of empties
auto scan_it = cudf::detail::make_counting_transform_iterator(
column_offsets[level], [off = lcv.offsets().data<size_type>()] __device__(auto i) -> int {
return off[i] == off[i + 1];
});
column_offsets[level],
robertmaynard marked this conversation as resolved.
Show resolved Hide resolved
[off = lcv.offsets().data<size_type>(), size = lcv.offsets().size()] __device__(
auto i) -> int { return (i + 1 < size) && (off[i] == off[i + 1]); });
rmm::device_uvector<size_type> scan_out(offset_size_at_level, stream);
thrust::exclusive_scan(
rmm::exec_policy(stream), scan_it, scan_it + offset_size_at_level, scan_out.begin());
Expand Down Expand Up @@ -2053,9 +2053,9 @@ dremel_data get_dremel_data(column_view h_col,
// Scan to get distance by which each offset value is shifted due to the insertion of dremel
// level value fof an empty list
auto scan_it = cudf::detail::make_counting_transform_iterator(
column_offsets[level], [off = lcv.offsets().data<size_type>()] __device__(auto i) -> int {
return off[i] == off[i + 1];
});
column_offsets[level],
[off = lcv.offsets().data<size_type>(), size = lcv.offsets().size()] __device__(
auto i) -> int { return (i + 1 < size) && (off[i] == off[i + 1]); });
rmm::device_uvector<size_type> scan_out(offset_size_at_level, stream);
thrust::exclusive_scan(
rmm::exec_policy(stream), scan_it, scan_it + offset_size_at_level, scan_out.begin());
Expand Down