A small optimization for JNI copy column view to column vector #8985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
revans2
added
3 - Ready for Review
jlowe
approved these changes
Aug 6, 2021
kuhushukla
approved these changes
Aug 6, 2021
nartal1
approved these changes
Aug 6, 2021
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #8985 +/- ##
===============================================
Coverage ? 10.59%
===============================================
Files ? 116
Lines ? 19034
Branches ? 0
===============================================
Hits ? 2017
Misses ? 17017
Partials ? 0 Continue to review full report at Codecov.
|
|
@gpucibot merge |
shwina
pushed a commit
to shwina/cudf
that referenced
this pull request
Aug 9, 2021
…sai#8985) So if the underlying class is a ColumnVector then we don't make a copy of the data, we just increment the reference count. Authors: - Robert (Bobby) Evans (https://github.com/revans2) Approvers: - Jason Lowe (https://github.com/jlowe) - Kuhu Shukla (https://github.com/kuhushukla) - Niranjan Artal (https://github.com/nartal1) URL: rapidsai#8985
vyasr
added
4 - Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So if the underlying class is a ColumnVector then we don't make a copy of the data, we just increment the reference count.