Add in more generalized support for casting nested types #3162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
build |
Signed-off-by: Robert (Bobby) Evans <[email protected]>
|
build |
jlowe
reviewed
Aug 6, 2021
shims/spark311/src/main/scala/com/nvidia/spark/rapids/shims/spark311/Spark311Shims.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/com/nvidia/spark/rapids/TypeChecks.scala
Outdated
Show resolved
Hide resolved
shims/spark311/src/main/scala/com/nvidia/spark/rapids/shims/spark311/Spark311Shims.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/com/nvidia/spark/rapids/TypeChecks.scala
Outdated
Show resolved
Hide resolved
jlowe
previously approved these changes
Aug 6, 2021
|
build |
|
build |
|
Got some scary test failures. Looking into it more. |
|
build |
|
There was a small bug in the existing cast code where it was using the member value |
jlowe
approved these changes
Aug 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #3156
This does not depend on rapidsai/cudf#8985, but it does help a lot with reducing unneeded data movement.
This adds support for casting structs to structs and maps to maps. It also generalizes support for casting arrays to arrays so that more types are supported. It also fixed a number of bugs in casting nested types.
I also added in an optimization from the original Spark cast code that checks to see if the types are structurally the same, meaning only the names of the fields in the struct changed, and if they are then it does not need to actually bother with the cast.