Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Support decimal cast from ColumnView #2043

Closed
rwlee opened this issue Mar 29, 2021 · 1 comment
Closed

[FEA] Support decimal cast from ColumnView #2043

rwlee opened this issue Mar 29, 2021 · 1 comment
Assignees
@revans2
Labels
task Work required that improves the product but is not user facing

Comments

@rwlee
Copy link
Contributor

rwlee commented Mar 29, 2021

Follow on issue for the conversion to casting from ColumnView rather than from ColumnVector done in #1814. The conversion was to allow for easier recursive casting when casting the child columns of structs.

The decimal family of casts had non-trivial uses of the ColumnVector originally used, like a potential zero-copy solution when converting from decimal to decimal. Currently the ColumnView is copied to a ColumnVector in the recursive calls and the decimal cases are filtered out in the top level doColumnar method.
@rwlee rwlee added feature request New feature or request ? - Needs Triage Need team to review and classify and removed ? - Needs Triage Need team to review and classify labels Mar 29, 2021
@rwlee rwlee mentioned this issue Mar 29, 2021
Merged
@sameerz sameerz added task Work required that improves the product but is not user facing and removed feature request New feature or request labels Dec 7, 2021
@revans2 revans2 self-assigned this Dec 7, 2021
@revans2
Copy link
Collaborator

revans2 commented Dec 7, 2021

I did this a while ago as a part of #3162

@revans2 revans2 closed this as completed Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@revans2 revans2

Labels
task Work required that improves the product but is not user facing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@revans2 @sameerz @rwlee