Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A small optimization for JNI copy column view to column vector #8985

Merged
merged 1 commit into from
Aug 6, 2021
Merged

A small optimization for JNI copy column view to column vector #8985

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion java/src/main/java/ai/rapids/cudf/ColumnVector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,16 @@ private ColumnVector(long viewAddress, DeviceMemoryBuffer contiguousBuffer) {
incRefCountInternal(true);
}


/**
* For a ColumnVector this is really just incrementing the reference count.
* @return this
*/
@Override
public ColumnVector copyToColumnVector() {
return incRefCount();
}

/**
* Retrieves the column_view for a cudf::column and if it fails to do so, the column is deleted
* and the exception is thrown to the caller.
Expand Down Expand Up @@ -803,7 +813,7 @@ private static native long stringConcatenation(long[] columnViews, long separato
/**
* Native method to concatenate columns of strings together using a separator specified for each row
* and returns the result as a string column.
* @param columns array of longs holding the native handles of the column_views to combine.
* @param columnViews array of longs holding the native handles of the column_views to combine.
* @param sep_column long holding the native handle of the strings_column_view used as separators.
* @param separator_narep string scalar indicating null behavior when a separator is null.
* If set to null and the separator is null the resulting string will
Expand Down