Add datetime::is_leap_year
#8711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isVoid
added
feature request
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #8711 +/- ##
===============================================
Coverage ? 10.67%
===============================================
Files ? 109
Lines ? 18670
Branches ? 0
===============================================
Hits ? 1993
Misses ? 16677
Partials ? 0 Continue to review full report at Codecov.
|
karthikeyann
requested changes
Jul 12, 2021
jrhemstad
reviewed
Jul 12, 2021
Co-authored-by: Karthikeyan <[email protected]>
|
The implementation has changed to largely reusing existing |
karthikeyann
approved these changes
Jul 13, 2021
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Jul 26, 2021
Partly addresses #8676. This PR adds `date_time:: extract_quarter`. The function returns an int `(1,2,3,4)` depending on which quarter of the year the date is in. Also fixed an incorrect date in previous testcase (#8711). Authors: - https://github.com/shaneding Approvers: - Nghia Truong (https://github.com/ttnghia) - Conor Hoekstra (https://github.com/codereport) URL: #8779
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 of #8677
This PR adds
datetime::is_leap_year. The function returnstruefor datetime column rows with leap year;falsefor rows with non leap years, andnullfor null rows.