Apply suggestions from code review

Co-authored-by: Karthikeyan <[email protected]>
rapidsai · Jul 12, 2021 · 37a1f96 · 37a1f96
1 parent 730edc6
commit 37a1f96
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 2 deletions.
diff --git a/cpp/include/cudf/datetime.hpp b/cpp/include/cudf/datetime.hpp
@@ -195,7 +195,7 @@ std::unique_ptr<cudf::column> add_calendrical_months(
  *
  * `output[i] == true` if year of `column[i]` is a leap year
  * `output[i] == false` if year of `column[i]` is not a leap year
- * `output[i] is null` if year of `column[i]` is null
+ * `output[i] is null` if `column[i]` is null
  *
  * @param[in] cudf::column_view of the input datetime values
  *

diff --git a/cpp/include/cudf/detail/datetime.hpp b/cpp/include/cudf/detail/datetime.hpp
@@ -132,6 +132,7 @@ std::unique_ptr<cudf::column> add_calendrical_months(
  */
 std::unique_ptr<cudf::column> is_leap_year(
   cudf::column_view const& column,
+  rmm::cuda_stream_view stream        = rmm::cuda_stream_default,
   rmm::mr::device_memory_resource* mr = rmm::mr::get_current_device_resource());
 
 }  // namespace detail

diff --git a/cpp/src/datetime/datetime_ops.cu b/cpp/src/datetime/datetime_ops.cu
@@ -22,7 +22,6 @@
 #include <cudf/detail/datetime.hpp>
 #include <cudf/detail/null_mask.hpp>
 #include <cudf/detail/nvtx/ranges.hpp>
-#include <cudf/null_mask.hpp>
 #include <cudf/table/table_view.hpp>
 #include <cudf/types.hpp>
 #include <cudf/utilities/traits.hpp>