Add quarters to libcudf datetime #8779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaneding
requested review from
robertmaynard and
codereport
and removed request for
a team
shaneding
added
feature request
|
As discussed many times in the past, please add more description clarifying what this PR is doing. Otherwise, the reviewers may have no idea about what to review. Just a link to an issue is not enough. |
jrhemstad
reviewed
Jul 20, 2021
codereport
suggested changes
Jul 21, 2021
shaneding
changed the title
ttnghia
requested changes
Jul 21, 2021
ttnghia
requested changes
Jul 21, 2021
jrhemstad
reviewed
Jul 22, 2021
ttnghia
approved these changes
Jul 22, 2021
ttnghia
reviewed
Jul 22, 2021
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #8779 +/- ##
================================================
- Coverage 10.67% 10.59% -0.09%
================================================
Files 110 116 +6
Lines 18271 19032 +761
================================================
+ Hits 1951 2017 +66
- Misses 16320 17015 +695
Continue to review full report at Codecov.
|
codereport
approved these changes
Jul 25, 2021
davidwendt
reviewed
Jul 25, 2021
Co-authored-by: David Wendt <[email protected]>
shaneding
added
5 - Ready to Merge
|
rerun tests |
|
@gpucibot merge |
1 similar comment
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Aug 10, 2021
Closes #8676. This PR adds python bindings for #8779. Authors: - https://github.com/shaneding Approvers: - Michael Wang (https://github.com/isVoid) - GALI PREM SAGAR (https://github.com/galipremsagar) URL: #8862
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly addresses #8676.
This PR adds
date_time:: extract_quarter. The function returns an int(1,2,3,4)depending on which quarter of the year the date is in. Also fixed an incorrect date in previous testcase (#8711).