Adding support for list and struct type in ORC Reader #8599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….read_orc(...). This allows for single calls to cudf.read_orc(...) and batching multiple read operations into a single read operation and therefore a single resulting dataframe
…t be specified multiple times
…ies multiple stripes from a single ORC file
rgsl888prabhu
added
3 - Ready for Review
vuule
requested changes
Jul 4, 2021
cpp/src/io/orc/orc.cpp
Outdated
Comment on lines
472
to
473
| uint32_t parent_idx = static_cast<uint32_t>(schema_idxs[col_id].parent); | ||
| uint32_t field_idx = static_cast<uint32_t>(schema_idxs[col_id].field); |
There was a problem hiding this comment.
Not a big deal, but the logic here is implicit/fragile. The invalid value (-1) is only covered in the next line because of unsigned integer underflow.
IMO there should be a validity check for schema_idxs[col_id].field (and maybe schema_idxs[col_id].parent, not sure) before we compare against fieldNames.size() and potentially set the column name.
galipremsagar
approved these changes
Jul 6, 2021
galipremsagar
added
5 - Ready to Merge
|
@gpucibot merge |
This was referenced Jul 7, 2021
rapids-bot bot
pushed a commit
that referenced
this pull request
Jul 12, 2021
The fix from #8174 got reverted in rework of `orc/reader_impl.cu` in #8599 This PR reinstates the original fix to prevent an assert in debug mode in `gtests/ORC_TEST` Authors: - David Wendt (https://github.com/davidwendt) Approvers: - Karthikeyan (https://github.com/karthikeyann) - Conor Hoekstra (https://github.com/codereport) URL: #8706
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for lists and struct in ORC reader.
The columns are processed as per nesting level since in case of list, you need to extract number of child rows per stripe and number of child rows in total, before you can process them.
But in case of struct, all the child columns will have same number of rows, so struct children are processed along with the parent in the same level.
So, you will observe that there is a distinction on how child columns of list and struct are handled in the PR.
closes #8582