-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix orc reader assert on create data_type #8174
Fix orc reader assert on create data_type #8174
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-0.20 #8174 +/- ##
===============================================
- Coverage 82.88% 82.85% -0.04%
===============================================
Files 103 104 +1
Lines 17668 17881 +213
===============================================
+ Hits 14645 14816 +171
- Misses 3023 3065 +42
Continue to review full report at Codecov.
|
@gpucibot merge |
The fix from #8174 got reverted in rework of `orc/reader_impl.cu` in #8599 This PR reinstates the original fix to prevent an assert in debug mode in `gtests/ORC_TEST` Authors: - David Wendt (https://github.com/davidwendt) Approvers: - Karthikeyan (https://github.com/karthikeyann) - Conor Hoekstra (https://github.com/codereport) URL: #8706
The following error shows in the gtests/ORC_TEST when run under libcudf built with Debug.
The assert occurs in the
data_type
constructor meant for fixed-point types only.cudf/cpp/include/cudf/types.hpp
Lines 265 to 268 in 96c0706
The orc reader implementation is using this ctor for all types and just passing 0 for the scale value when not a fixed-point type.
The assert only occurs in a debug build.
This PR changes the logic to call the appropriate
data_type
constructor depending on the type-id of the parsed column.