Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] ORC reader supports reading Struct columns. #2879

Closed
firestarman opened this issue Jul 7, 2021 · 5 comments · Fixed by #2887 or #3262
Closed

[FEA] ORC reader supports reading Struct columns. #2879

firestarman opened this issue Jul 7, 2021 · 5 comments · Fixed by #2887 or #3262
Assignees
@firestarman
Labels
feature request New feature or request P0 Must have for release

Comments

@firestarman
Copy link
Collaborator

cudf has added support for array and struct type in ORC reader by the PR rapidsai/cudf#8599 , so we can update the plugin side accordingly.
@firestarman firestarman added feature request New feature or request ? - Needs Triage Need team to review and classify labels Jul 7, 2021
@GaryShen2008 GaryShen2008 added P0 Must have for release and removed ? - Needs Triage Need team to review and classify labels Jul 7, 2021
@firestarman firestarman mentioned this issue Jul 8, 2021
Merged
@sameerz
Copy link
Collaborator

sameerz commented Jul 14, 2021

We need to make sure when we do nested pruning we either make sure that works when reading structs in ORC or fall back to the CPU. See issue #463 and issue #576

@firestarman firestarman mentioned this issue Jul 16, 2021
Merged
@firestarman
Copy link
Collaborator Author

firestarman commented Jul 21, 2021 •
edited
Loading

Done for supporting list, and the support of struct is in progress by #2887.

@firestarman firestarman changed the title [FEA] ORC reader supports reading Struct and Array columns. [FEA] ORC reader supports reading Struct columns. Jul 21, 2021
@tgravescs
Copy link
Collaborator

reopening because this was pulled back out with: #3079

@tgravescs tgravescs reopened this Jul 29, 2021
@tgravescs
Copy link
Collaborator

also note test failures #3059 and predicate pushdown #1481

@tgravescs tgravescs mentioned this issue Jul 29, 2021
Merged
@firestarman
Copy link
Collaborator Author

firestarman commented Jul 30, 2021 •
edited
Loading

This depends on rapidsai/cudf#8910, found by the issue #3059 .

And should also depend on rapidsai/cudf#8878, even no integration tests expose this error currently.

@firestarman firestarman mentioned this issue Aug 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@firestarman firestarman

Labels
feature request New feature or request P0 Must have for release
Projects
None yet
Milestone
No milestone
4 participants
@tgravescs @sameerz @firestarman @GaryShen2008