Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix debug compile error in gather_struct_tests.cpp #8554

Merged

Conversation

davidwendt
Copy link
Contributor

Building libcudf in debug resulted in a compile error introduced by #8527

../tests/copying/gather_struct_tests.cpp:87:32: error: suggest parentheses around ‘&&’ within ‘||’ [-Werror=parentheses]
   87 |       assert(gather_index >= 0 && gather_index < gather_map.size() ||
      |              ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

This error only shows in a debug build. This PR fixes the this code by applying the parentheses as the error suggests.

@davidwendt davidwendt added bug Something isn't working 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Jun 18, 2021
@davidwendt davidwendt self-assigned this Jun 18, 2021
@davidwendt davidwendt requested a review from a team as a code owner June 18, 2021 16:40
@codecov
Copy link

codecov bot commented Jun 18, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@8407309). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 118613c differs from pull request most recent head 16dc066. Consider uploading reports for the commit 16dc066 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #8554   +/-   ##
===============================================
  Coverage                ?   82.57%           
===============================================
  Files                   ?      109           
  Lines                   ?    17817           
  Branches                ?        0           
===============================================
  Hits                    ?    14713           
  Misses                  ?     3104           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8407309...16dc066. Read the comment docs.

@ttnghia
Copy link
Contributor

ttnghia commented Jun 20, 2021

This is duplicate of #8565

@vuule
Copy link
Contributor

vuule commented Jun 21, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 93fadf3 into rapidsai:branch-21.08 Jun 21, 2021
@davidwendt davidwendt deleted the debug-gather-struct-tests branch November 8, 2021 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants