Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address debug build errors #8565

Closed
wants to merge 1 commit into from

Conversation

gerashegalov
Copy link
Contributor

Fixes #8564

../tests/copying/gather_struct_tests.cpp:87:48: error: comparison of integer expressions of different signedness: ‘int’ and ‘std::vector<int>::size_type’ {aka ‘long unsigned int’} [-Werror=sign-compare]
   87 |       assert(gather_index >= 0 && gather_index < gather_map.size() || "Gather-index out of range.");
      |                                   ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~
../tests/copying/gather_struct_tests.cpp:87:32: error: suggest parentheses around ‘&&’ within ‘||’ [-Werror=parentheses]
   87 |       assert(gather_index >= 0 && gather_index < gather_map.size() || "Gather-index out of range.");
      |              ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1plus: all warnings being treated as errors

@gerashegalov gerashegalov requested a review from a team as a code owner June 19, 2021 19:19
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Jun 19, 2021
@gerashegalov gerashegalov self-assigned this Jun 19, 2021
@gerashegalov gerashegalov added 3 - Ready for Review Ready for review by team non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS bug Something isn't working labels Jun 19, 2021
@codecov
Copy link

codecov bot commented Jun 19, 2021

Codecov Report

Merging #8565 (3c5134e) into branch-21.08 (1de662f) will increase coverage by 0.37%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.08    #8565      +/-   ##
================================================
+ Coverage         82.57%   82.95%   +0.37%     
================================================
  Files               109      109              
  Lines             17817    18173     +356     
================================================
+ Hits              14713    15076     +363     
+ Misses             3104     3097       -7     
Impacted Files Coverage Δ
python/cudf/cudf/io/feather.py 100.00% <0.00%> (ø)
python/cudf/cudf/comm/serialize.py 0.00% <0.00%> (ø)
python/cudf/cudf/_fuzz_testing/io.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/applyutils.py 100.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/_version.py 0.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/io/tests/test_csv.py 100.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/io/tests/test_orc.py 100.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/io/tests/test_json.py 100.00% <0.00%> (ø)
...ython/dask_cudf/dask_cudf/io/tests/test_parquet.py 100.00% <0.00%> (ø)
python/cudf/cudf/core/column/numerical.py 94.17% <0.00%> (+0.01%) ⬆️
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1de662f...3c5134e. Read the comment docs.

@ttnghia
Copy link
Contributor

ttnghia commented Jun 20, 2021

This is duplicate of #8554.

Copy link
Contributor

@davidwendt davidwendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already being fixed in #8554. Recommend closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] BUILD_TYPE=Debug build breaks in an assert compile error
3 participants