Rename some copying_test source files .cu to .cpp #8527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
2 - In Progress
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #8527 +/- ##
===============================================
Coverage ? 82.95%
===============================================
Files ? 109
Lines ? 18226
Branches ? 0
===============================================
Hits ? 15120
Misses ? 3106
Partials ? 0 Continue to review full report at Codecov.
|
davidwendt
added
3 - Ready for Review
ttnghia
approved these changes
Jun 17, 2021
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Jun 21, 2021
Building libcudf in debug resulted in a compile error introduced by #8527 ``` ../tests/copying/gather_struct_tests.cpp:87:32: error: suggest parentheses around ‘&&’ within ‘||’ [-Werror=parentheses] 87 | assert(gather_index >= 0 && gather_index < gather_map.size() || | ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ``` This error only shows in a debug build. This PR fixes the this code by applying the parentheses as the error suggests. Authors: - David Wendt (https://github.com/davidwendt) Approvers: - Gera Shegalov (https://github.com/gerashegalov) - Nghia Truong (https://github.com/ttnghia) - MithunR (https://github.com/mythrocks) URL: #8554
rapids-bot bot
pushed a commit
that referenced
this pull request
Jun 23, 2021
Found this file can be changed to .cpp by modifying the `TypedColumnTest` to build its test data in the CPU and then cudaMemcpy it to the GPU. The remain ~1000 lines did not require any updates. Only a few `lists_column_wrapper` ctors needed to be corrected as similar to PR #8527. Authors: - David Wendt (https://github.com/davidwendt) Approvers: - Nghia Truong (https://github.com/ttnghia) - https://github.com/nvdbaranec - Mark Harris (https://github.com/harrism) URL: #8555
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found these files could be changed from .cu to .cpp while working on a different PR.
This PR renames these files and makes minimal updates (e.g removes unneeded includes of .cuh files) to make these compile and run as .cpp source files.