Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Push DeviceScalar construction into Cython for list.contains #7862

Closed
wants to merge 18 commits into from
Closed

Push DeviceScalar construction into Cython for list.contains #7862

wants to merge 18 commits into from

Conversation

brandon-b-miller
Copy link
Contributor

Fixes #7854

raydouglass and others added 18 commits March 25, 2021 14:22
@raydouglass
DOC v0.20 Updates
b2cb418
@GPUtester
Merge pull request rapidsai#7783 from rapidsai/branch-0.19
b703edc 
[gpuCI] Forward-merge branch-0.19 to branch-0.20 [skip ci]
@GPUtester
Merge pull request rapidsai#7784 from rapidsai/branch-0.19
d39cd97 
[gpuCI] Forward-merge branch-0.19 to branch-0.20 [skip ci]
@GPUtester
Merge pull request rapidsai#7792 from rapidsai/branch-0.19
d634e71 
[gpuCI] Forward-merge branch-0.19 to branch-0.20 [skip ci]
@GPUtester
Merge pull request rapidsai#7794 from rapidsai/branch-0.19
9bbae33 
[gpuCI] Forward-merge branch-0.19 to branch-0.20 [skip ci]
@pxLi
update Java bindings version to 0.20 (rapidsai#7747)
d804a47 
Updating the Java bindings package version to match the libcudf version for 0.20

also as [Deprecation announcement for CUDA 10.1 & 10.2 in v0.19](https://docs.rapids.ai/notices/rsn0005/), to update README to drop cuda 10.1 and cuda 10.2.

Please let me know if we are going to support other cuda version 11.x except 11.0

Authors:
  - pxLi (@pxLi)

Approvers:
  - Jason Lowe (@jlowe)
  - Robert (Bobby) Evans (@revans2)

URL: rapidsai#7747
@GPUtester
Merge pull request rapidsai#7796 from rapidsai/branch-0.19
d643b2b 
[gpuCI] Forward-merge branch-0.19 to branch-0.20 [skip ci]
@GPUtester
Merge pull request rapidsai#7797 from rapidsai/branch-0.19
96d6d84 
[gpuCI] Forward-merge branch-0.19 to branch-0.20 [skip ci]
@GPUtester
Merge pull request rapidsai#7799 from rapidsai/branch-0.19
ff951c6 
[gpuCI] Forward-merge branch-0.19 to branch-0.20 [skip ci]
@GPUtester
Merge pull request rapidsai#7800 from rapidsai/branch-0.19
ba55fa1 
[gpuCI] Forward-merge branch-0.19 to branch-0.20 [skip ci]
@GPUtester
Merge pull request rapidsai#7803 from rapidsai/branch-0.19
38ef37f 
[gpuCI] Forward-merge branch-0.19 to branch-0.20 [skip ci]
@GPUtester
Merge pull request rapidsai#7804 from rapidsai/branch-0.19
6e6b99e 
[gpuCI] Forward-merge branch-0.19 to branch-0.20 [skip ci]
@GPUtester
Merge pull request rapidsai#7806 from rapidsai/branch-0.19
1245f3d 
[gpuCI] Forward-merge branch-0.19 to branch-0.20 [skip ci]
@GPUtester
Merge pull request rapidsai#7808 from rapidsai/branch-0.19
8f621a3 
[gpuCI] Forward-merge branch-0.19 to branch-0.20 [skip ci]
@GPUtester
Merge pull request rapidsai#7810 from rapidsai/branch-0.19
f5f7444 
[gpuCI] Forward-merge branch-0.19 to branch-0.20 [skip ci]
@GPUtester
Merge pull request rapidsai#7814 from rapidsai/branch-0.19
90dda9c 
[gpuCI] Forward-merge branch-0.19 to branch-0.20 [skip ci]
@brandon-b-miller
create a cudf.Scalar around search_key
5a7e092
@brandon-b-miller
tests
7e4042e
@brandon-b-miller brandon-b-miller added bug Something isn't working 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. Cython non-breaking Non-breaking change labels Apr 5, 2021
@brandon-b-miller brandon-b-miller requested a review from a team as a code owner April 5, 2021 21:44
kkraus14
kkraus14 reviewed Apr 5, 2021
View reviewed changes
python/cudf/cudf/core/column/lists.py
@@ -237,9 +237,10 @@ def contains(self, search_key):
Series([False, True, True])
dtype: bool
"""
search_key = cudf.Scalar(search_key)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the only thing we were missing. Can we keep the Cython as taking a DeviceScalar with this change?

@kkraus14
Copy link
Collaborator

kkraus14 commented Apr 5, 2021

We may want to pull this into 0.19, this API is pretty unusable without this fix.

@kkraus14 kkraus14 changed the base branch from branch-0.20 to branch-0.19 April 5, 2021 21:56
@kkraus14 kkraus14 requested a review from a team as a code owner April 5, 2021 21:56
@kkraus14 kkraus14 requested review from a team as code owners April 5, 2021 21:56
@kkraus14 kkraus14 changed the base branch from branch-0.19 to branch-0.20 April 5, 2021 21:56
@kkraus14 kkraus14 removed request for a team April 5, 2021 21:58
@brandon-b-miller brandon-b-miller changed the base branch from branch-0.20 to branch-0.19 April 5, 2021 21:58
@brandon-b-miller
Copy link
Contributor Author

Closing to retarget 0.19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkraus14 kkraus14 kkraus14 left review comments

@cwharris cwharris Awaiting requested review from cwharris

@rgsl888prabhu rgsl888prabhu Awaiting requested review from rgsl888prabhu

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] list contains requires passing a device scalar
5 participants
@brandon-b-miller @kkraus14 @raydouglass @GPUtester @pxLi