Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gpuCI] Forward-merge branch-0.19 to branch-0.20 [skip ci] #7804

Merged
merged 1 commit into from
Apr 1, 2021

Conversation

GPUtester
Copy link
Collaborator

Forward-merge triggered by push to branch-0.19 that creates a PR to keep branch-0.20 up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge.

Closes #7498 

This PR adds binary comparison `eq`, `lt`, `gt`, `le`, `ge` to 

- [x] decimal column v. decimal column
- [x] decimal column v. decimal scalar (`decimal.Decimal` and decimal `cudf.Scalar`)
- [x] decimal column v. integer column (`cudf.utils.dtypes.INTEGER_TYPES`)
- [x] decimal column v. integer scalar    (Python ints)

Other minor adds:
- Supports binary ops between `cudf.DecimalColumn` and `cudf.Scalar`, where `Scalar.dtype` is `cudf.Decimal64Dtype` (follow up for #7732 )
- Short comment noting use of decimal64 in `decimals.pxd`
- Adding decimal data type in `basics.rst`

Authors:
  - Michael Wang (https://github.com/isVoid)

Approvers:
  - Keith Kraus (https://github.com/kkraus14)
  - GALI PREM SAGAR (https://github.com/galipremsagar)

URL: #7716
@GPUtester GPUtester requested a review from a team as a code owner April 1, 2021 01:36
@GPUtester
Copy link
Collaborator Author

SUCCESS - forward-merge complete.

@GPUtester GPUtester merged commit 6e6b99e into branch-0.20 Apr 1, 2021
@github-actions github-actions bot added the Python Affects Python cuDF API. label Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants