[gpuCI] Forward-merge branch-0.19 to branch-0.20 [skip ci] #7784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An implementation of get_json_object(). Reference: https://cwiki.apache.org/confluence/display/Hive/LanguageManual+UDF#LanguageManualUDF-get_json_object The fundamental functionality here is running a JSONPath query on each row in an input column of json strings. JSONPath spec: https://tools.ietf.org/id/draft-goessner-dispatch-jsonpath-00.html For review purposes, the key entry point is `parse_json_path()`. Each thread of the kernel processes 1 row via this function. The behavior is recursive in nature but we maintain our own context stack to do it in loop fashion. `parse_json_path` is just the high level controlling logic, with most of the heavy lifting happening in the `json_state` parser class. Though the "heavy lifting" is pretty much just traditional string parsing code. The path to optimization here (I'll open a separate cudf issue for this) is - Change `parse_json_path` to work on a warp basis. So each row in the column would be processed by one warp. - Make the `json_state` parser class thread/warp aware (the class would just store its `tid` and operate accordingly). I think this is reasonably straightforward to do as most of the cuIO decoding kernels behave like this. Authors: - @nvdbaranec - Raza Jafri (@razajafri) Approvers: - Ray Douglass (@raydouglass) - Jason Lowe (@jlowe) - Jake Hemstad (@jrhemstad) - David (@davidwendt) URL: #7286
|
SUCCESS - forward-merge complete. |
github-actions
bot
added
CMake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward-merge triggered by push to
branch-0.19that creates a PR to keepbranch-0.20up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge.