Fix java float/double parsing tests [skip ci] #7473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orrectly handles inf and nan.
…sue-5225 # Conflicts: # cpp/benchmarks/CMakeLists.txt
… fix_double_parse_tests
…sue-5225 # Conflicts: # cpp/benchmarks/CMakeLists.txt
… fix_double_parse_tests
…sue-5225 # Conflicts: # cpp/benchmarks/CMakeLists.txt
… fix_double_parse_tests
…sue-5225 # Conflicts: # cpp/benchmarks/CMakeLists.txt
…rk.cpp Co-authored-by: David <[email protected]>
… fix_double_parse_tests
github-actions
bot
added
CMake
revans2
changed the title
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7473 +/- ##
===============================================
+ Coverage 81.80% 82.28% +0.47%
===============================================
Files 101 101
Lines 16695 17247 +552
===============================================
+ Hits 13658 14191 +533
- Misses 3037 3056 +19
Continue to review full report at Codecov.
|
github-actions
bot
removed
libcudf
jlowe
changed the title
jlowe
approved these changes
Mar 2, 2021
|
@gpucibot merge |
| "1.7976931348623159E308", | ||
| "-1.7976931348623157E308", | ||
| // Current CUDF Code does not detect overflow for this. "-1.7976931348623158E308", | ||
| // So we make it a little larger for this test |
vyasr
added
4 - Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a part of #7410 and depends on it. The java tests when they were first written, for what ever reason, did not use the correct string representation for several values including double max. They ended up testing that the code was broken, which is not the right thing to do. This updates those to have the correct values, but also has a comment about why the ideal value to test for overflow into
Infand-Infis not ideal, but is a work around for small issues with the parsing code still.