-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix java float/double parsing tests [skip ci] #7473
Merged
rapids-bot
merged 30 commits into
rapidsai:branch-0.19
from
revans2:fix_double_parse_tests
Mar 2, 2021
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
7a93e07
Add a benchmark for string <=> floats conversion.
ttnghia 3ea06fb
Fix error and improve the function converting fromn string to float t…
ttnghia 4bfd906
Fix the equivalent check function for floating point numbers that inc…
ttnghia 0cfdbcd
Add a test for converting string to double number
ttnghia 7778f85
Merge remote-tracking branch 'origin/branch-0.19' into branch-0.19-is…
ttnghia a5ede5d
Update copyright header
ttnghia 2584840
Fix const qualifier position and change CMakeLists.txt
ttnghia ca58e26
Merge branch 'branch-0.19-issue-5225' of github.com:ttnghia/cudf into…
revans2 c23fdfc
Fix java tests for parsing double values
revans2 7fadcd0
Some improvement to atof
ttnghia f3ead3d
Use the results generated from std::stof to test our atof implementation
ttnghia 30e98b3
Add a simple test case
ttnghia 354e65e
Fix convert_floats_benchmark
ttnghia 983d69e
Merge branch 'branch-0.19' into fix_double_parse_tests
revans2 4a5ca65
Merge branch 'branch-0.19-issue-5225' of github.com:ttnghia/cudf into…
revans2 0130e51
Merge remote-tracking branch 'origin/branch-0.19' into branch-0.19-is…
ttnghia dd7139e
Merge branch 'branch-0.19-issue-5225' of github.com:ttnghia/cudf into…
revans2 d411f7f
Merge remote-tracking branch 'origin/branch-0.19' into branch-0.19-is…
ttnghia 8f5a580
Improve accuracy by casting from string to double then to float
ttnghia 0c6fbb0
Merge branch 'branch-0.19-issue-5225' of github.com:ttnghia/cudf into…
revans2 a112a1b
Change the template function `stof` to a regular function `stod`.
ttnghia f8077a7
Re-instating important comment
ttnghia 1238dba
Minor change in handling nan in typed_element_not_equivalent struct
ttnghia 4aaa83f
Simplify data generation and change ranges for the benchmarks
ttnghia 6b1af3b
Merge remote-tracking branch 'origin/branch-0.19' into branch-0.19-is…
ttnghia 3a7c52e
Update header format for cpp/benchmarks/string/convert_floats_benchma…
ttnghia bb9595e
Merge branch 'branch-0.19' into fix_double_parse_tests
revans2 587127c
Merge branch 'branch-0.19-issue-5225' of github.com:ttnghia/cudf into…
revans2 d32c9b6
Updated tests
revans2 c1bb3f7
Merge branch 'branch-0.19' into fix_double_parse_tests
revans2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
smaller?