Fix string to double conversion and row equivalent comparison #7410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orrectly handles inf and nan.
github-actions
bot
added
CMake
ttnghia
added
3 - Ready for Review
…sue-5225 # Conflicts: # cpp/benchmarks/CMakeLists.txt
ttnghia
changed the title
davidwendt
requested changes
Feb 18, 2021
jrhemstad
reviewed
Feb 18, 2021
…sue-5225 # Conflicts: # cpp/benchmarks/CMakeLists.txt
ttnghia
added
the
5 - Ready to Merge
davidwendt
requested changes
Feb 23, 2021
…rk.cpp Co-authored-by: David <[email protected]>
davidwendt
approved these changes
Feb 23, 2021
vuule
requested changes
Feb 26, 2021
…generate columns of strings by calling to cudf::strings::to_floats
vuule
approved these changes
Mar 1, 2021
|
@gpucibot merge. |
|
@ttnghia you can't merge if CI is not passing... |
|
@gpucibot rerun tests |
|
I see. Thanks Mark. |
# Conflicts: # cpp/benchmarks/CMakeLists.txt
|
@gpucibot merge. |
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Mar 2, 2021
This is a part of #7410 and depends on it. The java tests when they were first written, for what ever reason, did not use the correct string representation for several values including double max. They ended up testing that the code was broken, which is not the right thing to do. This updates those to have the correct values, but also has a comment about why the ideal value to test for overflow into `Inf` and `-Inf` is not ideal, but is a work around for small issues with the parsing code still. Authors: - Robert (Bobby) Evans (@revans2) - Nghia Truong (@ttnghia) Approvers: - Jason Lowe (@jlowe) URL: #7473
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #5225 and fixes #5731 along with several improvements. In particular:
stodinconvert_floats.cu, which incorrectly usesmax_mantissa, thus produces incorrect results as mentioned in the issue [BUG] discrepency in casting String to double #5225. Note that this PR still cannot produce perfectly matched results withstd::atof, since handling float values nearinfis very difficult.corresponding_rows_not_equivalentwhich didn't handleinfandnan, thus it returned "equivalent" when comparing a valid float number withinf.std::atofresults for comparison.