-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Upgrade pandas to 1.2 #7375
Conversation
rerun tests |
@gpucibot merge |
@@ -45,6 +45,7 @@ requirements: | |||
- fsspec>=0.6.0 | |||
- {{ pin_compatible('cudatoolkit', max_pin='x.x') }} | |||
- nvtx >=0.2.1 | |||
- packaging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to be added to the integration
repo as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would defer to @ajschmidt8 here, there was a build job-related failure at this line https://github.com/rapidsai/cudf/blob/branch-0.19/ci/cpu/build.sh#L78-L79 so AJ suggested we add it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup, i will open a PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to review. I will wait to merge until this PR is confirmed passing also.
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7375 +/- ##
===============================================
+ Coverage 81.80% 82.33% +0.52%
===============================================
Files 101 101
Lines 16695 17198 +503
===============================================
+ Hits 13658 14160 +502
- Misses 3037 3038 +1
Continue to review full report at Codecov.
|
Fixes: #7367, #7446
This PR upgrades pandas to
1.2.2
incudf
. Changes include:pandas
version.isin
behavior which now takes in types into accout: DOC: Undocumented change in .isin behavior from 1.1.5 to 1.2.0 pandas-dev/pandas#38781CategoricalColumn.__setitem__
will now not allow setting of values that are not in existing categories.cudf.core._compat.PANDAS_GE_120
variable to create back-ward compatibility.pd.core.tools.datetimes._guess_datetime_format
topd.core.tools.datetimes.guess_datetime_format
std
&median
inDateTimeColumn
.StringMethods
as an input to methods in string APIs.is_valid
ofScalar
.TimeDeltaColumn.sum
logic for empty inputs.dtype='float64'
wherever there is an empty series being created since pandas will soon be defaulting toobject
dtype if no type is passed and we don't have a perfectly resemblingobject
dtype as that of pandas.Index.__or__
andIndex.__xor__
by replacing withunion
&symmetric_difference
APIs.float32
&float64
dtypes to pandas Nullable dtypesFLoat32Dtype
&Float64Dtype
whennullable=True
into_pandas
.MultiIndex
from dataframe: BUG: Unable to create a MultiIndex withnan
values in nullableFloat
dtypes pandas-dev/pandas#39984, so introduced a workaround in ourMultiIndex.__repr__
code.check_less_precise
in our code-base as this is deprecated and is replaced withrtol
&atol
. Retained its usages in our testing APIs for back-ward compatibility.xfail
cases which are actually passing right now because of resolved issues in bothpandas
&cudf
.from pandas import Series
and some dofrom cudf.core import Series
. So removed both patterns and doing only simpleimport cudf
&import pandas as pd
to avoid confusion while debugging test failures across multiple files. (Made this change in all pytest files which I had to touch as part of pandas upgrade, we can make similar changes in future for the files which we touch).np.nan
values to aCategoricalColumn
and fix related__repr__
code: [BUG] Unable to assignnull
/nan
in categorical column #7446