Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Add isin examples in Docstring #7479

Merged
merged 3 commits into from
Mar 2, 2021

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Mar 1, 2021

Fully resolves: #7412

Most of the fix to address #7412 were done as part of pandas upgrade in #7375. This PR only includes docstrings update to isin.

@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team doc Documentation Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer labels Mar 1, 2021
@galipremsagar galipremsagar requested review from shwina and kkraus14 March 1, 2021 22:54
@galipremsagar galipremsagar self-assigned this Mar 1, 2021
@galipremsagar galipremsagar requested a review from a team as a code owner March 1, 2021 22:54
@galipremsagar galipremsagar added the non-breaking Non-breaking change label Mar 1, 2021
@kkraus14 kkraus14 added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Mar 2, 2021
@kkraus14
Copy link
Collaborator

kkraus14 commented Mar 2, 2021

@gpucibot merge

@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #7479 (c42750b) into branch-0.19 (43b44e1) will increase coverage by 0.05%.
The diff coverage is 87.63%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #7479      +/-   ##
===============================================
+ Coverage        81.80%   81.86%   +0.05%     
===============================================
  Files              101      101              
  Lines            16695    16883     +188     
===============================================
+ Hits             13658    13821     +163     
- Misses            3037     3062      +25     
Impacted Files Coverage Δ
python/cudf/cudf/utils/docutils.py 97.36% <50.00%> (-2.64%) ⬇️
python/cudf/cudf/testing/testing.py 80.00% <57.14%> (-1.04%) ⬇️
python/cudf/cudf/core/column/timedelta.py 88.23% <75.00%> (ø)
python/cudf/cudf/core/column/categorical.py 91.38% <77.14%> (-0.85%) ⬇️
python/cudf/cudf/core/column/datetime.py 89.09% <78.57%> (+0.04%) ⬆️
python/dask_cudf/dask_cudf/core.py 71.67% <79.41%> (-2.60%) ⬇️
python/cudf/cudf/core/multiindex.py 82.28% <90.90%> (+0.12%) ⬆️
python/cudf/cudf/core/tools/datetimes.py 84.44% <93.33%> (+0.80%) ⬆️
python/cudf/cudf/core/column_accessor.py 95.31% <95.65%> (+2.37%) ⬆️
python/cudf/cudf/core/column/column.py 87.76% <96.42%> (+0.34%) ⬆️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4c1dba...c42750b. Read the comment docs.

@rapids-bot rapids-bot bot merged commit f4f4d87 into rapidsai:branch-0.19 Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge doc Documentation non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] isin behavior change while handling inputs of different dtype
2 participants