Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix strings::detail::copy_range when target contains nulls #16626

Merged
merged 4 commits into from
Aug 27, 2024

Conversation

davidwendt
Copy link
Contributor

@davidwendt davidwendt commented Aug 21, 2024

Description

Fixes the logic in cudf::strings::detail::copy_range handling of nulls in the target range. The optimization check for nulls is removed simplifying the logic and making it more reliable as well. The benchmark showed no significant change in performance.
Also adds a specific gtest for this case.
Error was introduced in #15010
Closes #16618

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added bug Something isn't working 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Aug 21, 2024
@davidwendt davidwendt self-assigned this Aug 21, 2024
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Aug 22, 2024
@davidwendt davidwendt marked this pull request as ready for review August 23, 2024 15:57
@davidwendt davidwendt requested a review from a team as a code owner August 23, 2024 15:57
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit e2a15cb into rapidsai:branch-24.10 Aug 27, 2024
80 checks passed
@davidwendt davidwendt deleted the copy-range-strings branch August 27, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] cudaErrorIllegalAddress while copying values to nullable string series
3 participants