Rework cudf::strings::detail::copy_range for offsetalator #15010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
2 - In Progress
davidwendt
added
3 - Ready for Review
robertmaynard
approved these changes
Feb 15, 2024
vuule
reviewed
Feb 15, 2024
vuule
requested changes
Feb 15, 2024
vuule
approved these changes
Feb 16, 2024
|
/merge |
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
Aug 27, 2024
Fixes the logic in `cudf::strings::detail::copy_range` handling of nulls in the target range. The optimization check for nulls is removed simplifying the logic and making it more reliable as well. The benchmark showed no significant change in performance. Also adds a specific gtest for this case. Error was introduced in #15010 Closes #16618 Authors: - David Wendt (https://github.com/davidwendt) Approvers: - Nghia Truong (https://github.com/ttnghia) - Bradley Dice (https://github.com/bdice) URL: #16626
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This reworks the
cudf::strings::detail::copy_range()function to use the offsetalator instead of accessing the output offsets directly. Also refactored the code to remove the unnecessary template arguments. And added a benchmark to ensure these changes did not cause a performance impact.Most of the code in
cpp/include/cudf/strings/detail/copy_range.cuhwas rewritten and moved tocpp/src/strings/copying/copy_range.cu.Checklist