Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] cudaErrorIllegalAddress while copying values to nullable string series #16618

Closed
cwharris opened this issue Aug 20, 2024 · 1 comment · Fixed by #16626
Closed

[BUG] cudaErrorIllegalAddress while copying values to nullable string series #16618

cwharris opened this issue Aug 20, 2024 · 1 comment · Fixed by #16626
Assignees
Labels
bug Something isn't working

Comments

@cwharris
Copy link
Contributor

cwharris commented Aug 20, 2024

Describe the bug
cudaErrorIllegalAddress while copying values to nullable string series. This is a regression from the behavior in 24.02.

Steps/Code to reproduce bug

cudf.Series(['a', None])[1:2] = ['b'] # cudaErrorIllegalAddress

However, the following does work:

cudf.Series(['a', 'b'])[1:2] = ['c'] # works

as does:

cudf.Series([0, 1])[1:2] = [2] # works

Expected behavior
expected the value to be copied to the specified range without causing cudaErrorIllegalAddress

Environment overview (please complete the following information)

  • Environment location: Docker
  • Method of cuDF install: conda

Additional context
Morpheus depends heavily on this behavior.

@cwharris cwharris added the bug Something isn't working label Aug 20, 2024
@davidwendt
Copy link
Contributor

Also this works

cudf.Series(['a', None])[1:2] = 'b'

Broken down just to make sure:

>>> import cudf
>>> s = cudf.Series(['a', None])
>>> s[1:2] = 'b'
>>> s
0    a
1    b
dtype: object

rapids-bot bot pushed a commit that referenced this issue Aug 27, 2024
Fixes the logic in `cudf::strings::detail::copy_range` handling of nulls in the target range. The optimization check for nulls is removed simplifying the logic and making it more reliable as well. The benchmark showed no significant change in performance.
Also adds a specific gtest for this case.
Error was introduced in #15010
Closes #16618

Authors:
  - David Wendt (https://github.com/davidwendt)

Approvers:
  - Nghia Truong (https://github.com/ttnghia)
  - Bradley Dice (https://github.com/bdice)

URL: #16626
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants