Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward-merge branch-24.04 into branch-24.06 [skip ci] #15330

Merged
merged 6 commits into from
Mar 19, 2024

Conversation

rapids-bot[bot]
Copy link

@rapids-bot rapids-bot bot commented Mar 18, 2024

Forward-merge triggered by push to branch-24.04 that creates a PR to keep branch-24.06 up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge. See forward-merger docs for more info.

This PR updates the script inputs in the relevant workflows from
`build_script` and `test_script` to `script`.

Depends on rapidsai/shared-workflows#191
@rapids-bot rapids-bot bot requested a review from a team as a code owner March 18, 2024 18:55
Copy link

copy-pr-bot bot commented Mar 18, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Copy link
Author

rapids-bot bot commented Mar 18, 2024

FAILURE - Unable to forward-merge due to an error, manual merge is necessary. Do not use the Resolve conflicts option in this PR, follow these instructions https://docs.rapids.ai/maintainers/forward-merger/

IMPORTANT: When merging this PR, do not use the auto-merger (i.e. the /merge comment). Instead, an admin must manually merge by changing the merging strategy to Create a Merge Commit. Otherwise, history will be lost and the branches become incompatible.

Resolves #15310. Contributes to #15193

In addition, this PR adds pylibcudf.Column<-->pyarrow.Array interconversion as a benefit

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Matthew Roeschke (https://github.com/mroeschke)

URL: #15325
@rapids-bot rapids-bot bot requested a review from a team as a code owner March 18, 2024 22:13
@rapids-bot rapids-bot bot requested review from vyasr and bdice March 18, 2024 22:13
@github-actions github-actions bot added Python Affects Python cuDF API. CMake CMake build issue labels Mar 18, 2024
This PR also introduces `std::out_of_range` to cudf's code base in cases where it is appropriate.

Contributes to #12885 
Resolves #15315 
Contributes to #15162

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #15319
@rapids-bot rapids-bot bot requested a review from a team as a code owner March 18, 2024 22:22
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Mar 18, 2024
In the Parquet writer, `decimal64` stats were being treated like `decimal128` (i.e. written in network byte order), when they should be treated like an `int64_t`. This PR fixes that and adds tests of `decimal32` and `decimal64` statistics.

Authors:
  - Ed Seidl (https://github.com/etseidl)
  - Vukasin Milovanovic (https://github.com/vuule)

Approvers:
  - David Wendt (https://github.com/davidwendt)
  - MithunR (https://github.com/mythrocks)
  - Vukasin Milovanovic (https://github.com/vuule)

URL: #15281
shrshi and others added 2 commits March 19, 2024 03:48
…15324)

This PR addresses the inconsistency in processing single quotes within a quoted string in the single quote normalizer. 
In the current implementation, when we have an escaped single quote within a single quoted string, the normalizer removes the backslash escape on converting the string to double quotes. However, the normalizer retains the contents of double quoted strings as-is i.e. if there are escaped single quotes within a double quoted string, the backslash character is retained in the output. 

We address this inconsistency by removing the escape character for single quotes in all double quoted string in the output.

Tackles #15303 to mimic Spark behavior.

Authors:
  - Shruti Shivakumar (https://github.com/shrshi)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Elias Stehle (https://github.com/elstehle)
  - Vukasin Milovanovic (https://github.com/vuule)

URL: #15324
…r_test.cu` (#15200)

In `parquet_chunked_reader_test.cu`, when generating test data, there is an `offset` value that should increase at every iteration. It is for shifting the null positions of each column such that the generating table will not have all nulls in the same rows. Somehow, it was left unchanged across all iterations, thus we need to fix that.

Authors:
  - Nghia Truong (https://github.com/ttnghia)
  - Karthikeyan (https://github.com/karthikeyann)

Approvers:
  - https://github.com/nvdbaranec
  - Bradley Dice (https://github.com/bdice)
  - Karthikeyan (https://github.com/karthikeyann)

URL: #15200
@galipremsagar galipremsagar added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Mar 19, 2024
@galipremsagar galipremsagar changed the title Forward-merge branch-24.04 into branch-24.06 [skip ci] Forward-merge branch-24.04 into branch-24.06 [skip ci Mar 19, 2024
@galipremsagar galipremsagar changed the title Forward-merge branch-24.04 into branch-24.06 [skip ci Forward-merge branch-24.04 into branch-24.06 [skip ci] Mar 19, 2024
@raydouglass raydouglass merged commit a07740a into branch-24.06 Mar 19, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants