Initiate switch from build_script and test_script to script
#191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raydouglass
reviewed
Mar 13, 2024
AyodeAwe
force-pushed
the
fix_inconsistencies
branch
from
907283e to
2749951
Compare
AyodeAwe
changed the title
build_script and test_script to script
raydouglass
approved these changes
Mar 14, 2024
ajschmidt8
reviewed
Mar 14, 2024
ajschmidt8
approved these changes
Mar 14, 2024
This was referenced Mar 14, 2024
rapids-bot bot
pushed a commit
to rapidsai/wholegraph
that referenced
this pull request
Mar 15, 2024
This PR updates the script inputs in the relevant workflows from `build_script` and `test_script` to `script`. Depends on rapidsai/shared-workflows#191 Authors: - Jake Awe (https://github.com/AyodeAwe) Approvers: - Ray Douglass (https://github.com/raydouglass) URL: #147
AyodeAwe
added a commit
to rapidsai/cudf
that referenced
this pull request
Mar 18, 2024
This PR updates the script inputs in the relevant workflows from `build_script` and `test_script` to `script`. Depends on rapidsai/shared-workflows#191
AyodeAwe
added a commit
to rapidsai/pynvjitlink
that referenced
this pull request
Mar 18, 2024
This PR updates the script inputs in the relevant workflows from `build_script` and `test_script` to `script`. Depends on rapidsai/shared-workflows#191 The PR also updates `24.02` references to `24.04`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script used in wheel workflows is indicated by
script, whereas the conda workflows usebuild_scriptandtest_script.This PR initiates a switch for the conda build and test workflows (cpp, python) to use the
scriptinput name. After this PR is merged, PRs will be opened to all RAPIDS repositories which call these workflows to update the inputs frombuild_scriptandtest_script(if these are present in the workflows) toscript.The rationale is that the naming convention of
build_scriptandtest_scriptappear rather redundant given the name of their respective workflows (cpp_build,cpp_test, etc.)After these PRs are merged, another PR will be opened in this repository to remove the
build_scriptandtest_scriptreferences for these shared workflows.This PR also adds a name for the conda build job, keeping it consistent with the named wheels build job.