Change exceptions thrown by copying APIs #15319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
added
libcudf
|
Note to reviewers: let's discuss the usage of |
bdice
reviewed
Mar 15, 2024
| @@ -368,13 +368,16 @@ template <typename IndexIterator> | |||
| size_type validate_segmented_indices(IndexIterator indices_begin, IndexIterator indices_end) | |||
| { | |||
| auto const num_indices = static_cast<size_type>(std::distance(indices_begin, indices_end)); | |||
There was a problem hiding this comment.
Should this be using thrust::distance instead of std::distance? I'm not sure if std::distance works on all iterator types. (I could be wrong here.)
There was a problem hiding this comment.
That's a good question. I think it's worth making the change since I can see some code paths that call through to this with thrust iterators. I'm guessing everything works fine or we'd be seeing bugs, but best to be safe nonetheless.
I'll do this in a separate PR though.
bdice
approved these changes
Mar 18, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR also introduces
std::out_of_rangeto cudf's code base in cases where it is appropriate.Contributes to #12885
Resolves #15315
Contributes to #15162
Checklist