Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JNI] Disable testChunkedPackTwoPasses for now #15210

Merged
merged 2 commits into from
Mar 4, 2024
Merged

[JNI] Disable testChunkedPackTwoPasses for now #15210

merged 2 commits into from
Mar 4, 2024

Conversation

abellina
Copy link
Contributor

@abellina abellina commented Mar 1, 2024

This relates to #15209 and is a temporary fix to stop breaking the CI for everyone.

We are going to continue investigating the failure in TableTest.testchunkedPackTwoPasses.

@abellina abellina requested a review from a team as a code owner March 1, 2024 20:53
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Mar 1, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added the Java Affects Java cuDF API. label Mar 1, 2024
@abellina abellina added non-breaking Non-breaking change bug Something isn't working tests Unit testing for project labels Mar 1, 2024
@vuule
Copy link
Contributor

vuule commented Mar 1, 2024

/ok to test

@davidwendt davidwendt mentioned this pull request Mar 1, 2024
Closed
@abellina
Copy link
Contributor Author

abellina commented Mar 2, 2024

The python builds are failing, and I am not entirely sure why. This passes java tests and that's the only change made.

Could/should this be admin merged?

@ttnghia
Copy link
Contributor

ttnghia commented Mar 2, 2024

/ok to test

@galipremsagar
Copy link
Contributor

The python builds are failing, and I am not entirely sure why. This passes java tests and that's the only change made.

Could/should this be admin merged?

The python failures are fixed by this PR: #15212

@abellina
Copy link
Contributor Author

abellina commented Mar 2, 2024 •
edited
Loading

The python builds are failing, and I am not entirely sure why. This passes java tests and that's the only change made.
Could/should this be admin merged?

The python failures are fixed by this PR: #15212

Your PR is blocked by the Java tests that my PR will fix (sadly). @galipremsagar do you want to subsume my pr and add it to yours? It may make this go a lot faster.

We can try rerunning Java tests in yours, or admin merge my PR as well.

@bdice
Copy link
Contributor

bdice commented Mar 4, 2024

I proposed an admin merge on both #15210 (this PR) and #15212. I think that's the best path forward to unblocking CI failures.

@bdice bdice mentioned this pull request Mar 4, 2024
Merged
3 tasks
@AyodeAwe AyodeAwe merged commit 8dbe7cb into rapidsai:branch-24.04 Mar 4, 2024
69 of 75 checks passed
@abellina abellina mentioned this pull request Mar 4, 2024
Merged
3 tasks
rapids-bot bot pushed a commit that referenced this pull request Mar 5, 2024
@abellina
Fix testchunkedPackTwoPasses to copy from the bounce buffer (#15220)
f804aa6 
This is a follow on from #15210. We bring back the test and fix it so it copies from the right buffer this time. I also set the original column to have some values and nulls, to make sure we are checking something interesting.

Authors:
  - Alessandro Bellina (https://github.com/abellina)

Approvers:
  - Nghia Truong (https://github.com/ttnghia)
  - Gera Shegalov (https://github.com/gerashegalov)

URL: #15220
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia approved these changes

@bdice bdice bdice approved these changes

@revans2 revans2 revans2 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working Java Affects Java cuDF API. non-breaking Non-breaking change tests Unit testing for project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@abellina @vuule @ttnghia @galipremsagar @bdice @revans2 @AyodeAwe