Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix accessing .columns by an external API #15212

Merged
merged 3 commits into from
Mar 4, 2024
Merged

Fix accessing .columns by an external API #15212

merged 3 commits into from
Mar 4, 2024

Conversation

galipremsagar
Copy link
Contributor

Description

pa.pandas_compat.construct_metadata seems to be accessing .columns of cudf.DataFrame, this is unsafe and expensive, so instead this PR will only return empty rows and only a pandas DataFrame. While doing so, uncovered and fixed issues with column type preservation in head API.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added bug Something isn't working 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs Review Waiting for reviewer to review or respond non-breaking Non-breaking change labels Mar 1, 2024
@galipremsagar galipremsagar self-assigned this Mar 1, 2024
@galipremsagar galipremsagar requested a review from a team as a code owner March 1, 2024 22:20
@galipremsagar galipremsagar requested review from wence- and vyasr March 1, 2024 22:20
bdice
bdice approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This looks like a good fix for the original problem and the bug you found along the way.

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond labels Mar 1, 2024
@galipremsagar
Copy link
Contributor Author

/merge

@galipremsagar galipremsagar mentioned this pull request Mar 2, 2024
Merged
@ttnghia
Copy link
Contributor

ttnghia commented Mar 2, 2024

/merge

@bdice
Copy link
Contributor

bdice commented Mar 4, 2024

I proposed an admin merge on both #15212 (this PR) and #15210. I think that's the best path forward to unblocking CI failures.

@AyodeAwe AyodeAwe merged commit 903dcac into rapidsai:branch-24.04 Mar 4, 2024
75 of 76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia approved these changes

@bdice bdice bdice approved these changes

@wence- wence- Awaiting requested review from wence- wence- is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@galipremsagar @ttnghia @bdice @AyodeAwe