Fix testchunkedPackTwoPasses to copy from the bounce buffer #15220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alessandro Bellina <[email protected]>
abellina
added
bug
|
/ok to test |
ttnghia
approved these changes
Mar 4, 2024
gerashegalov
approved these changes
Mar 4, 2024
Comment on lines
3748
to
3751
| for (int i = 0; i < longs.length; i++) { | ||
| // fill the column and set every other value to null | ||
| longs[i] = i % 2 == 0 ? null : (long)i; | ||
| } |
There was a problem hiding this comment.
Since null is the default value for object references we could simply skip even positions
Suggested change
| for (int i = 0; i < longs.length; i++) { | |
| // fill the column and set every other value to null | |
| longs[i] = i % 2 == 0 ? null : (long)i; | |
| } | |
| // Initialize elements at odd-numbered indices | |
| for (int i = 1; i < longs.length; i += 2) { | |
| longs[i] = (long)i; | |
| } |
There was a problem hiding this comment.
Will the untouched values of longs be uninitialized (containing garbage value)?
There was a problem hiding this comment.
https://docs.oracle.com/javase/specs/jls/se21/html/jls-4.html#jls-4.12.5
Each class variable, instance variable, or array component is initialized with a default value when it is created
...
for all reference types (§4.3), the default value is null.
Signed-off-by: Alessandro Bellina <[email protected]>
|
/ok to test |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow on from #15210. We bring back the test and fix it so it copies from the right buffer this time. I also set the original column to have some values and nulls, to make sure we are checking something interesting.
Checklist