-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip numba test that fails on ARM #14702
Skip numba test that fails on ARM #14702
Conversation
@@ -1,4 +1,4 @@ | |||
# SPDX-FileCopyrightText: Copyright (c) 2023 NVIDIA CORPORATION & AFFILIATES. | |||
# SPDX-FileCopyrightText: Copyright (c) 2023-2024, NVIDIA CORPORATION & AFFILIATES. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is failing style checks for a really gross reason. This is too long of a line. There's one other case where I could see this, but I don't love the solution:
cudf/python/cudf/cudf/core/resample.py
Lines 1 to 3 in af65d52
# SPDX-FileCopyrightText: Copyright (c) 2021-2023, NVIDIA CORPORATION & | |
# AFFILIATES. All rights reserved. SPDX-License-Identifier: | |
# Apache-2.0 |
We probably need to have a discussion about what we ought to do here. I'd hate to let the line-length make this suffer from awful formatting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can the copyright section be exempted from check somehow? It's not really a "comment" in the normal sense I'd say.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could # noqa
but that’s even noisier and not better imo. I am inclined to say that if we require SPDX compatible license headers with all of the current wording, we have to increase the line length limits.
cc: @shwina for input
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated this to 83.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. The other consideration I would raise (while hopefully avoiding bike shedding too much) is that 88 is the next most popular line length limit after 79/80. The black formatter defaults to 88. It might be wise to align with a common standard.
https://black.readthedocs.io/en/stable/the_black_code_style/current_style.html#line-length
/merge |
Nightly jobs have been failing with a numba segfault.
This appears to be a longstanding issue with numba on aarch64 fixed by numba/llvmlite#1009. Technically, the issue exists already in our tests, but it appears that changes from numba 0.58 make the conditions for the issue to occur much more likely, hence the failures occurring after removing the numba 0.58 version constraint recently. The issue should be fixed in numba 0.59.
For now however we should skip things so that nightlies can be fixed.