Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip numba test that fails on ARM #14702

Merged
merged 6 commits into from
Jan 5, 2024
Merged

Skip numba test that fails on ARM #14702

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
55e2f39
skip flaky numba 0.58 test
brandon-b-miller Jan 3, 2024
0e39001
Update python/cudf/cudf_pandas_tests/test_cudf_pandas.py
brandon-b-miller Jan 3, 2024
d21bf5d
Merge branch 'branch-24.02' into fix-numba-058-segfaults
brandon-b-miller Jan 4, 2024
d0ea1c8
update line lengths
brandon-b-miller Jan 4, 2024
be819e2
fix style
brandon-b-miller Jan 4, 2024
cd3e947
Update pyproject.toml
brandon-b-miller Jan 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ exclude = [
# TODO: Remove this in a follow-up where we fix __all__.
"__init__.py",
]
line-length = 79
line-length = 88

[tool.ruff.per-file-ignores]
# Lots of pytest implicitly injected attributes in conftest-patch.py
Expand Down
5 changes: 4 additions & 1 deletion python/cudf/cudf_pandas_tests/test_cudf_pandas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# SPDX-FileCopyrightText: Copyright (c) 2023 NVIDIA CORPORATION & AFFILIATES.
# SPDX-FileCopyrightText: Copyright (c) 2023-2024, NVIDIA CORPORATION & AFFILIATES.
Copy link
Contributor

@bdice bdice Jan 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is failing style checks for a really gross reason. This is too long of a line. There's one other case where I could see this, but I don't love the solution:

cudf/python/cudf/cudf/core/resample.py

Lines 1 to 3 in af65d52

# SPDX-FileCopyrightText: Copyright (c) 2021-2023, NVIDIA CORPORATION &
# AFFILIATES. All rights reserved. SPDX-License-Identifier:
# Apache-2.0

We probably need to have a discussion about what we ought to do here. I'd hate to let the line-length make this suffer from awful formatting.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can the copyright section be exempted from check somehow? It's not really a "comment" in the normal sense I'd say.

Copy link
Contributor

@bdice bdice Jan 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could # noqa but that’s even noisier and not better imo. I am inclined to say that if we require SPDX compatible license headers with all of the current wording, we have to increase the line length limits.

cc: @shwina for input

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated this to 83.

Copy link
Contributor

@bdice bdice Jan 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. The other consideration I would raise (while hopefully avoiding bike shedding too much) is that 88 is the next most popular line length limit after 79/80. The black formatter defaults to 88. It might be wise to align with a common standard.

https://black.readthedocs.io/en/stable/the_black_code_style/current_style.html#line-length

# All rights reserved.
# SPDX-License-Identifier: Apache-2.0

Expand Down Expand Up @@ -668,6 +668,9 @@ def test_rolling_win_type():
tm.assert_equal(result, expected)


@pytest.mark.skip(
reason="Requires Numba 0.59 to fix segfaults on ARM. See https://github.com/numba/llvmlite/pull/1009"
)
def test_rolling_apply_numba_engine():
def weighted_mean(x):
arr = np.ones((1, x.shape[1]))
Expand Down